Remove --if-needed flag from update.py |
||||
Issue description
tools/clang/scripts/update.py:
# TODO(phajdan.jr): remove --if-needed after fixing callers. It's no-op.
parser.add_argument('--if-needed', action='store_true',
help="run only if the script thinks clang is needed")
Here's a bug for that so I can set blockers. https://chromium-review.googlesource.com/c/chromium/tools/build/+/1176622 removed a dead reference to that flag too.
Also need to remove from
infra/recipes/recipes/publish_tarball.py
infra/recipes/recipes/build_from_tarball.py
,
Aug 16
Assigning to get this out of triage
,
Aug 16
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ffc658ed7ad267e52f2c8aceade3c9d0a45194d commit 0ffc658ed7ad267e52f2c8aceade3c9d0a45194d Author: Nico Weber <thakis@chromium.org> Date: Fri Jan 04 21:27:39 2019 clang/update.py: Remove unused, no-op --if-needed flag. Bug: 874689 Change-Id: I71c2d13d9c31a55a80edf10b4b574e438773627d Reviewed-on: https://chromium-review.googlesource.com/c/1395888 Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#620068} [modify] https://crrev.com/0ffc658ed7ad267e52f2c8aceade3c9d0a45194d/tools/clang/scripts/update.py
,
Jan 4
,
Jan 5
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f90feb2a01dda21a6c27bf44cd2a8e1329e26035 commit f90feb2a01dda21a6c27bf44cd2a8e1329e26035 Author: Peter K. Lee <pkl@google.com> Date: Sat Jan 05 22:52:40 2019 |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Aug 16