New issue
Advanced search Search tips

Issue 874677 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in blink::IntersectionObserver::Create

Project Member Reported by ClusterFuzz, Aug 15

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5145023646269440

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::IntersectionObserver::Create
  constructor
  blink::V8IntersectionObserver::constructorCallback
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:553024

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5145023646269440

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 15

Components: Blink
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Components: -Blink Blink>Layout
Cc: kkaluri@chromium.org
Labels: M-69 Test-Predator-Wrong
Owner: szager@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using Code Search for the file, "intersection_observer.cc" suspecting the below Cl might have caused this issue

Suspect CL: https://chromium.googlesource.com/chromium/src/+/533d95e8eb5b2e2fd74bed8170fab29c967fd3b8

szager@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Cc: pdr@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44a84f0f233f4575405e0d2d93a8407691cd0401

commit 44a84f0f233f4575405e0d2d93a8407691cd0401
Author: Stefan Zager <szager@chromium.org>
Date: Sun Aug 26 00:13:01 2018

[IntersectionObserver] Properly clamp threshold arguments to float

BUG= 874677 
R=pdr@chromium.org

Change-Id: I55cf0111906307211668dd6a1448787b7e971586
Reviewed-on: https://chromium-review.googlesource.com/1188586
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586156}
[modify] https://crrev.com/44a84f0f233f4575405e0d2d93a8407691cd0401/third_party/blink/renderer/core/intersection_observer/intersection_observer.cc

Project Member

Comment 6 by ClusterFuzz, Nov 29

ClusterFuzz has detected this issue as fixed in range 611648:611649.

Detailed report: https://clusterfuzz.com/testcase?key=5145023646269440

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::IntersectionObserver::Create
  constructor
  blink::V8IntersectionObserver::constructorCallback
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:553024
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=611648:611649

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5145023646269440

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 29

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5145023646269440 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment