New issue
Advanced search Search tips

Issue 874667 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Aug 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ChromeSitePerProcessPDFTest.SendSyntheticTapGestureOOPIF" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 15 
"ChromeSitePerProcessPDFTest.SendSyntheticTapGestureOOPIF" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQwsSBUZsYWtlIjhDaHJvbWVTaXRlUGVyUHJvY2Vzc1BERlRlc3QuU2VuZFN5bnRoZXRpY1RhcEdlc3R1cmVPT1BJRgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8376c83f55c9dffb695a6f8f2b49cc4c563a0f9

commit d8376c83f55c9dffb695a6f8f2b49cc4c563a0f9
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Aug 15 23:19:53 2018

Revert "Set touch action Auto in MaybeSendSyntheticTapGesture"

This reverts commit ec552f22953973871cea1e625cf6b366c8c36345.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 583369 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWM1NTJmMjI5NTM5NzM4NzFjZWExZTYyNWNmNmIzNjZjOGMzNjM0NQw

Sample Failed Build: https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/71344

Sample Failed Step: mash_browser_tests (with patch)

Sample Flaky Test: ChromeSitePerProcessPDFTest.SendSyntheticTapGestureOOPIF

Original change's description:
> Set touch action Auto in MaybeSendSyntheticTapGesture
> 
> The MaybeSendSyntheticTapGesture can be called in PreProcessMouseEvent,
> in which case the TouchActionFilter::allowed_touch_action_ has no value
> and will result in a crash.
> 
> This CL set the allowed_touch_action_ to auto to fix the issue. A
> browser test is added.
> 
> Bug:  873211 
> Change-Id: If776a93fe2c8f7a311a10bc0fec42cda15d0ae9a
> Reviewed-on: https://chromium-review.googlesource.com/1169585
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583369}

Change-Id: I2b4c4fb6b76a7a904603e7bf1086fe4f42d9f1e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  873211 ,  874667 
Reviewed-on: https://chromium-review.googlesource.com/1176503
Cr-Commit-Position: refs/heads/master@{#583438}
[modify] https://crrev.com/d8376c83f55c9dffb695a6f8f2b49cc4c563a0f9/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/d8376c83f55c9dffb695a6f8f2b49cc4c563a0f9/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/d8376c83f55c9dffb695a6f8f2b49cc4c563a0f9/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/d8376c83f55c9dffb695a6f8f2b49cc4c563a0f9/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/d8376c83f55c9dffb695a6f8f2b49cc4c563a0f9/content/public/test/browser_test_utils.h

Comment 3 by nhiroki@chromium.org, Aug 16

Status: Fixed (was: Untriaged)
(Chromium Sheriff) The flaky test was reverted.

Comment 4 by nhiroki@chromium.org, Aug 16 

 Issue 874666  has been merged into this issue.
►

Sign in to add a comment