New issue
Advanced search Search tips

Issue 874659 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: ----
Proj-Servicification



Sign in to add a comment

Migrate DNS Resolver for socket_api.cc

Project Member Reported by dxie@google.com, Aug 15

Issue description


 
Components: Internals>Services>Network
Status: Available (was: InternalsServicesNetworking)
Cc: jam@chromium.org
Labels: Proj-Servicification-Canary
Owner: cduvall@chromium.org
Status: Assigned (was: Available)
clarke, assign it to you since this is in the extension area.

Please make it available if you can't get to it.
Cc: ericorth@chromium.org
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e00670e5690602d4baac5cda6e2dbf73cd6971a3

commit e00670e5690602d4baac5cda6e2dbf73cd6971a3
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Aug 17 18:10:47 2018

Convert socket_api.cc to mojo host resolver

This is similar to dns_api.cc, in that there is no way to cancel the
request.

Bug:  874659 
Change-Id: I7fdc70d786a7b86e3a92ea2c8de6a108bcfa2aaf
Reviewed-on: https://chromium-review.googlesource.com/1179263
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584126}
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/chrome/browser/extensions/api/socket/socket_apitest.cc
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/BUILD.gn
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/browser/api/dns/BUILD.gn
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/browser/api/dns/dns_api.cc
[delete] https://crrev.com/c3873af52ba49802154c16ede8c90afe5d1c9cce/extensions/browser/api/dns/host_resolver_wrapper.cc
[delete] https://crrev.com/c3873af52ba49802154c16ede8c90afe5d1c9cce/extensions/browser/api/dns/host_resolver_wrapper.h
[delete] https://crrev.com/c3873af52ba49802154c16ede8c90afe5d1c9cce/extensions/browser/api/dns/mock_host_resolver_creator.cc
[delete] https://crrev.com/c3873af52ba49802154c16ede8c90afe5d1c9cce/extensions/browser/api/dns/mock_host_resolver_creator.h
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/browser/api/socket/socket_api.h
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/browser/api/socket/socket_apitest.cc
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc
[modify] https://crrev.com/e00670e5690602d4baac5cda6e2dbf73cd6971a3/extensions/browser/api/sockets_udp/sockets_udp_apitest.cc

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad2bcf962a18956b3f201df813f4c90e205ad311

commit ad2bcf962a18956b3f201df813f4c90e205ad311
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Aug 17 20:02:44 2018

Remove socket test from network server browser_test filter

http://crrev.com/c/1179263 switched
SocketExtensionWithDnsLookupFunction::StartDnsLookup to use mojo API.

Bug:  874659 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia65b22c593e6df68dfc20b60942747015a46cc8d
Reviewed-on: https://chromium-review.googlesource.com/1180256
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584161}
[modify] https://crrev.com/ad2bcf962a18956b3f201df813f4c90e205ad311/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Sign in to add a comment