Issue metadata
Sign in to add a comment
|
Migrate DNS Resolver for network_hints_message_filter.cc |
||||||||||||||||||||||
Issue description
,
Aug 15
,
Aug 15
,
Aug 16
Are you sure about these tags? As far as I (well, code search) can see NetworkHintsMessageFilter is only ever instantiated in chromecast/browser/cast_content_browser_client.cc
,
Aug 16
Note to whomever does the migration on this one: This resolve request is setting the |is_speculative| flag with a comment that that will reduce priority. That flag has no effect on priority (only logging and observers), so we should check if we want reduced priority and actually set IDLE accordingly.
,
Aug 16
jam/cduvall/ericorth, can you please comment on #4. I also did a cs and confirms comment#4 is correct. If that's the case, this probably won't block windows canary.
,
Aug 16
Thanks for bringing that up Maks.
,
Aug 20
If the code is only ever used in chromecast, agreed that this is not a canary blocker.
,
Aug 20
,
Aug 21
,
Aug 23
,
Aug 23
,
Sep 4
,
Sep 4
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/624207a7c1a366dd2f80c05dcf6af0ad074c5f58 commit 624207a7c1a366dd2f80c05dcf6af0ad074c5f58 Author: Jun Cai <juncai@chromium.org> Date: Tue Sep 04 18:07:08 2018 Network Service: Convert network_hints_message_filter.cc to mojo host resolver Bug: 874654 Change-Id: I096673342b280bad76ba856d6ee01c5a453bc1d8 Reviewed-on: https://chromium-review.googlesource.com/1187507 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#588585} [modify] https://crrev.com/624207a7c1a366dd2f80c05dcf6af0ad074c5f58/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/624207a7c1a366dd2f80c05dcf6af0ad074c5f58/components/network_hints/browser/BUILD.gn [modify] https://crrev.com/624207a7c1a366dd2f80c05dcf6af0ad074c5f58/components/network_hints/browser/DEPS [modify] https://crrev.com/624207a7c1a366dd2f80c05dcf6af0ad074c5f58/components/network_hints/browser/network_hints_message_filter.cc [modify] https://crrev.com/624207a7c1a366dd2f80c05dcf6af0ad074c5f58/components/network_hints/browser/network_hints_message_filter.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dxie@chromium.org
, Aug 15Status: Available (was: InternalsServicesNetworking)