I don't think it makes sense to prioritize this; the returned address is used for a socket in the browser process, and this is all to connect to devices for devtools, so it's probably not the sort of thing where cache state could affect loading performance dramatically (same for  crbug.com/874651 ).

How much work is it to do this? We want URLRequestContext to not be instantiated in the browser when network service is enabled. I don't know if it's feasible to do this before canary or not.

It doesn't touch URLRequestContext at all. It's not too much work either, though, since it's just straight up a DNS call + wiring in the Profile to it through a bunch of layers, but it seems to start off from DevToolsAndroidBridge which is a BrowserKeyedSource.

Hmm, not sure of the lifetime though.

Thank you for the explanation, ok agreed this doesn't need to block canary.

I'm not as worried about cache affecting performance as I am about privacy issues since we need user-data-clearing code to clear the correct caches.

But in this case, I think we're safe to call it a non-blocker.  As noted above, it doesn't use URLRequestContext.  Instead the code currently creates a separate resolver with a separate cache.  Not using the shared cache; not a canary blocker.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac880b3ad00b2f206ff8a9fddaff004763370b03

commit ac880b3ad00b2f206ff8a9fddaff004763370b03
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Aug 28 16:33:57 2018

Convert tcp_device_provider.cc to mojo host resolver

Bug:  874653 
Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
Reviewed-on: https://chromium-review.googlesource.com/1185626
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586738}
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/chrome_devtools_manager_delegate.h
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/chrome_devtools_session.cc
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/device/cast_device_provider.cc
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/device/cast_device_provider.h
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/device/cast_device_provider_unittest.cc
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/device/tcp_device_provider.cc
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/device/tcp_device_provider.h
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/protocol/target_handler.cc
[modify] https://crrev.com/ac880b3ad00b2f206ff8a9fddaff004763370b03/chrome/browser/devtools/protocol/target_handler.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d241becc763d91ffb9bd542ec35234401a05c10

commit 7d241becc763d91ffb9bd542ec35234401a05c10
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Aug 30 19:17:48 2018

Revert "Convert tcp_device_provider.cc to mojo host resolver"

This reverts commit ac880b3ad00b2f206ff8a9fddaff004763370b03.

Reason for revert: Causing crash after audit in incognito window:  http://crbug.com/879060 

Original change's description:
> Convert tcp_device_provider.cc to mojo host resolver
>
> Bug:  874653 
> Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> Reviewed-on: https://chromium-review.googlesource.com/1185626
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586738}

TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  874653 ,  879060 
Change-Id: I72e7268a8b208a2f91e53f84601d5e89a3c66a41
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1197109
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587693}
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/chrome_devtools_manager_delegate.h
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/chrome_devtools_session.cc
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/cast_device_provider.cc
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/cast_device_provider.h
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/cast_device_provider_unittest.cc
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/tcp_device_provider.cc
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/tcp_device_provider.h
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/protocol/target_handler.cc
[modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/protocol/target_handler.h

This was causing a crash when the browser context is destroyed when TCPDeviceProvider still tries to use it to reinitialize the host resolver, see  issue 879060 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6493250fe611b19a614864d8040446066f0134c0

commit 6493250fe611b19a614864d8040446066f0134c0
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Aug 30 20:44:54 2018

Reland "Convert tcp_device_provider.cc to mojo host resolver"

This is a reland of ac880b3ad00b2f206ff8a9fddaff004763370b03

Switched to using
ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
outlives TCPDeviceProvider. The original was reverted because of a
crash when TCPDeviceProvider tried to access a destroyed
BrowserContext, see  http://crbug.com/879060 .

Original change's description:
> Convert tcp_device_provider.cc to mojo host resolver
>
> Bug:  874653 
> Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> Reviewed-on: https://chromium-review.googlesource.com/1185626
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586738}

Bug:  874653 
Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
Reviewed-on: https://chromium-review.googlesource.com/1197265
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587750}
[modify] https://crrev.com/6493250fe611b19a614864d8040446066f0134c0/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/6493250fe611b19a614864d8040446066f0134c0/chrome/browser/devtools/device/cast_device_provider.cc
[modify] https://crrev.com/6493250fe611b19a614864d8040446066f0134c0/chrome/browser/devtools/device/cast_device_provider.h
[modify] https://crrev.com/6493250fe611b19a614864d8040446066f0134c0/chrome/browser/devtools/device/cast_device_provider_unittest.cc
[modify] https://crrev.com/6493250fe611b19a614864d8040446066f0134c0/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/6493250fe611b19a614864d8040446066f0134c0/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/6493250fe611b19a614864d8040446066f0134c0/chrome/browser/devtools/device/tcp_device_provider.cc
[modify] https://crrev.com/6493250fe611b19a614864d8040446066f0134c0/chrome/browser/devtools/device/tcp_device_provider.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da9bf1cfbf2322a851c57d03a81984bbc54da873

commit da9bf1cfbf2322a851c57d03a81984bbc54da873
Author: Matt Menke <mmenke@chromium.org>
Date: Fri Aug 31 15:29:48 2018

Revert "Reland "Convert tcp_device_provider.cc to mojo host resolver""

This reverts commit 6493250fe611b19a614864d8040446066f0134c0.

Reason for revert: This is a top crasher on Canary. See
https://crash.corp.google.com/browse?q=product_name%3D%27Chrome%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27canary%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3A%60anonymous+namespace%5C%27%3A%3AGetStoragePartitionMap%27&stbtiq=&reportid=&index=0

Original change's description:
> Reland "Convert tcp_device_provider.cc to mojo host resolver"
> 
> This is a reland of ac880b3ad00b2f206ff8a9fddaff004763370b03
> 
> Switched to using
> ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
> outlives TCPDeviceProvider. The original was reverted because of a
> crash when TCPDeviceProvider tried to access a destroyed
> BrowserContext, see  http://crbug.com/879060 .
> 
> Original change's description:
> > Convert tcp_device_provider.cc to mojo host resolver
> >
> > Bug:  874653 
> > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> > Reviewed-on: https://chromium-review.googlesource.com/1185626
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#586738}
> 
> Bug:  874653 
> Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
> Reviewed-on: https://chromium-review.googlesource.com/1197265
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587750}

TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org

Change-Id: I10a1bc2d22694a2f11be28bc5acb925610a7a017
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  874653 
Reviewed-on: https://chromium-review.googlesource.com/1199565
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588028}
[modify] https://crrev.com/da9bf1cfbf2322a851c57d03a81984bbc54da873/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/da9bf1cfbf2322a851c57d03a81984bbc54da873/chrome/browser/devtools/device/cast_device_provider.cc
[modify] https://crrev.com/da9bf1cfbf2322a851c57d03a81984bbc54da873/chrome/browser/devtools/device/cast_device_provider.h
[modify] https://crrev.com/da9bf1cfbf2322a851c57d03a81984bbc54da873/chrome/browser/devtools/device/cast_device_provider_unittest.cc
[modify] https://crrev.com/da9bf1cfbf2322a851c57d03a81984bbc54da873/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/da9bf1cfbf2322a851c57d03a81984bbc54da873/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/da9bf1cfbf2322a851c57d03a81984bbc54da873/chrome/browser/devtools/device/tcp_device_provider.cc
[modify] https://crrev.com/da9bf1cfbf2322a851c57d03a81984bbc54da873/chrome/browser/devtools/device/tcp_device_provider.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6edc8c87d588d8d651817953b50f1f1cda12191d

commit 6edc8c87d588d8d651817953b50f1f1cda12191d
Author: Matt Menke <mmenke@chromium.org>
Date: Fri Aug 31 15:56:52 2018

Reland "Reland "Convert tcp_device_provider.cc to mojo host resolver""

This reverts commit da9bf1cfbf2322a851c57d03a81984bbc54da873.

Reason for revert: Looks like I may have reverted this due to
crashes that this CL was already reworked to fix.

Original change's description:
> Revert "Reland "Convert tcp_device_provider.cc to mojo host resolver""
> 
> This reverts commit 6493250fe611b19a614864d8040446066f0134c0.
> 
> Reason for revert: This is a top crasher on Canary. See
> https://crash.corp.google.com/browse?q=product_name%3D%27Chrome%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27canary%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3A%60anonymous+namespace%5C%27%3A%3AGetStoragePartitionMap%27&stbtiq=&reportid=&index=0
> 
> Original change's description:
> > Reland "Convert tcp_device_provider.cc to mojo host resolver"
> > 
> > This is a reland of ac880b3ad00b2f206ff8a9fddaff004763370b03
> > 
> > Switched to using
> > ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
> > outlives TCPDeviceProvider. The original was reverted because of a
> > crash when TCPDeviceProvider tried to access a destroyed
> > BrowserContext, see  http://crbug.com/879060 .
> > 
> > Original change's description:
> > > Convert tcp_device_provider.cc to mojo host resolver
> > >
> > > Bug:  874653 
> > > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> > > Reviewed-on: https://chromium-review.googlesource.com/1185626
> > > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#586738}
> > 
> > Bug:  874653 
> > Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
> > Reviewed-on: https://chromium-review.googlesource.com/1197265
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#587750}
> 
> TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org
> 
> Change-Id: I10a1bc2d22694a2f11be28bc5acb925610a7a017
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  874653 
> Reviewed-on: https://chromium-review.googlesource.com/1199565
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588028}

TBR=caseq@chromium.org,mmenke@chromium.org,ericorth@chromium.org,cduvall@chromium.org

Change-Id: I584f46586aaef26203dddbcdbfdf0fd7e2be0741
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  874653 
Reviewed-on: https://chromium-review.googlesource.com/1199566
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588040}
[modify] https://crrev.com/6edc8c87d588d8d651817953b50f1f1cda12191d/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/6edc8c87d588d8d651817953b50f1f1cda12191d/chrome/browser/devtools/device/cast_device_provider.cc
[modify] https://crrev.com/6edc8c87d588d8d651817953b50f1f1cda12191d/chrome/browser/devtools/device/cast_device_provider.h
[modify] https://crrev.com/6edc8c87d588d8d651817953b50f1f1cda12191d/chrome/browser/devtools/device/cast_device_provider_unittest.cc
[modify] https://crrev.com/6edc8c87d588d8d651817953b50f1f1cda12191d/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/6edc8c87d588d8d651817953b50f1f1cda12191d/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/6edc8c87d588d8d651817953b50f1f1cda12191d/chrome/browser/devtools/device/tcp_device_provider.cc
[modify] https://crrev.com/6edc8c87d588d8d651817953b50f1f1cda12191d/chrome/browser/devtools/device/tcp_device_provider.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5366af89f848a97cec903214919f48fb0df98809

commit 5366af89f848a97cec903214919f48fb0df98809
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Aug 31 17:40:41 2018

Revert "Reland "Convert tcp_device_provider.cc to mojo host resolver""

This reverts commit 6493250fe611b19a614864d8040446066f0134c0.

Reason for revert: Breaks when opening devtools on debug build.

Original change's description:
> Reland "Convert tcp_device_provider.cc to mojo host resolver"
> 
> This is a reland of ac880b3ad00b2f206ff8a9fddaff004763370b03
> 
> Switched to using
> ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
> outlives TCPDeviceProvider. The original was reverted because of a
> crash when TCPDeviceProvider tried to access a destroyed
> BrowserContext, see  http://crbug.com/879060 .
> 
> Original change's description:
> > Convert tcp_device_provider.cc to mojo host resolver
> >
> > Bug:  874653 
> > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> > Reviewed-on: https://chromium-review.googlesource.com/1185626
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#586738}
> 
> Bug:  874653 
> Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
> Reviewed-on: https://chromium-review.googlesource.com/1197265
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587750}

TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org

Change-Id: Iaf8ef85f3696e6fc290b505edeb7989a99adab29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  874653 
Reviewed-on: https://chromium-review.googlesource.com/1199709
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588075}
[modify] https://crrev.com/5366af89f848a97cec903214919f48fb0df98809/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/5366af89f848a97cec903214919f48fb0df98809/chrome/browser/devtools/device/cast_device_provider.cc
[modify] https://crrev.com/5366af89f848a97cec903214919f48fb0df98809/chrome/browser/devtools/device/cast_device_provider.h
[modify] https://crrev.com/5366af89f848a97cec903214919f48fb0df98809/chrome/browser/devtools/device/cast_device_provider_unittest.cc
[modify] https://crrev.com/5366af89f848a97cec903214919f48fb0df98809/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/5366af89f848a97cec903214919f48fb0df98809/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/5366af89f848a97cec903214919f48fb0df98809/chrome/browser/devtools/device/tcp_device_provider.cc
[modify] https://crrev.com/5366af89f848a97cec903214919f48fb0df98809/chrome/browser/devtools/device/tcp_device_provider.h

I would like to merge http://crrev.com/c/1199709 (see comment #22) into M70, it should be a clean revert of a broken CL that made it into the branch.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approved 

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 3bcda527677557bf40b46cf1e2b65e0b7c5556e0 was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!

Relanded in http://crrev.com/c/1199848.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6af9f9ee6e47e5797ea0cc5b4137144ef8d019a0

commit 6af9f9ee6e47e5797ea0cc5b4137144ef8d019a0
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Sep 05 16:51:14 2018

Reland "Reland "Convert tcp_device_provider.cc to mojo host resolver""

This is a reland of 6493250fe611b19a614864d8040446066f0134c0

There were reports of crashes when opening devtools because of a DCHECK
deep inside GetActiveUserProfile. This switches to using the system
network context, as suggested by mmenke@. This also simplifies things
quite a bit as we don't have to pass around a BrowserContext.

Original change's description:
> Reland "Convert tcp_device_provider.cc to mojo host resolver"
>
> This is a reland of ac880b3ad00b2f206ff8a9fddaff004763370b03
>
> Switched to using
> ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
> outlives TCPDeviceProvider. The original was reverted because of a
> crash when TCPDeviceProvider tried to access a destroyed
> BrowserContext, see  http://crbug.com/879060 .
>
> Original change's description:
> > Convert tcp_device_provider.cc to mojo host resolver
> >
> > Bug:  874653 
> > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> > Reviewed-on: https://chromium-review.googlesource.com/1185626
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#586738}
>
> Bug:  874653 
> Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
> Reviewed-on: https://chromium-review.googlesource.com/1197265
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587750}

Bug:  874653 
Change-Id: Ifc6eddc0d05bd65792165d5542fe98b09ff0fb05
Reviewed-on: https://chromium-review.googlesource.com/1199848
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588890}
[modify] https://crrev.com/6af9f9ee6e47e5797ea0cc5b4137144ef8d019a0/chrome/browser/devtools/device/tcp_device_provider.cc
[modify] https://crrev.com/6af9f9ee6e47e5797ea0cc5b4137144ef8d019a0/chrome/browser/devtools/device/tcp_device_provider.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bcda527677557bf40b46cf1e2b65e0b7c5556e0

commit 3bcda527677557bf40b46cf1e2b65e0b7c5556e0
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Sep 04 22:15:28 2018

Revert "Reland "Convert tcp_device_provider.cc to mojo host resolver""

This reverts commit 6493250fe611b19a614864d8040446066f0134c0.

Reason for revert: Breaks when opening devtools on debug build.

Original change's description:
> Reland "Convert tcp_device_provider.cc to mojo host resolver"
> 
> This is a reland of ac880b3ad00b2f206ff8a9fddaff004763370b03
> 
> Switched to using
> ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
> outlives TCPDeviceProvider. The original was reverted because of a
> crash when TCPDeviceProvider tried to access a destroyed
> BrowserContext, see  http://crbug.com/879060 .
> 
> Original change's description:
> > Convert tcp_device_provider.cc to mojo host resolver
> >
> > Bug:  874653 
> > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> > Reviewed-on: https://chromium-review.googlesource.com/1185626
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#586738}
> 
> Bug:  874653 
> Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
> Reviewed-on: https://chromium-review.googlesource.com/1197265
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587750}

TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org

Change-Id: Iaf8ef85f3696e6fc290b505edeb7989a99adab29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  874653 
Reviewed-on: https://chromium-review.googlesource.com/1199709
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588075}(cherry picked from commit 5366af89f848a97cec903214919f48fb0df98809)
Reviewed-on: https://chromium-review.googlesource.com/1205490
Cr-Commit-Position: refs/branch-heads/3538@{#35}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/3bcda527677557bf40b46cf1e2b65e0b7c5556e0/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/3bcda527677557bf40b46cf1e2b65e0b7c5556e0/chrome/browser/devtools/device/cast_device_provider.cc
[modify] https://crrev.com/3bcda527677557bf40b46cf1e2b65e0b7c5556e0/chrome/browser/devtools/device/cast_device_provider.h
[modify] https://crrev.com/3bcda527677557bf40b46cf1e2b65e0b7c5556e0/chrome/browser/devtools/device/cast_device_provider_unittest.cc
[modify] https://crrev.com/3bcda527677557bf40b46cf1e2b65e0b7c5556e0/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/3bcda527677557bf40b46cf1e2b65e0b7c5556e0/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/3bcda527677557bf40b46cf1e2b65e0b7c5556e0/chrome/browser/devtools/device/tcp_device_provider.cc
[modify] https://crrev.com/3bcda527677557bf40b46cf1e2b65e0b7c5556e0/chrome/browser/devtools/device/tcp_device_provider.h