Migrate DNS Resolver for port_forwarding_controller.cc |
|||||||||||||||||
Issue description
,
Aug 15
,
Aug 15
,
Aug 16
I don't think it makes sense to prioritize this; the returned address is used for a socket in the browser process, and this is all to connect to devices for devtools, so it's probably not the sort of thing where cache state could affect loading performance dramatically (same for crbug.com/874653 ).
,
Aug 16
Thanks for the background.
,
Aug 20
Like the other devtools case, looks like this is creating its own separate cache, so I agree this is not a canary blocker.
,
Aug 20
,
Aug 21
,
Aug 21
,
Aug 21
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e3e6c835acc68d8962a0beb98ccf866564b82e7 commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7 Author: Jun Cai <juncai@chromium.org> Date: Thu Aug 23 23:44:39 2018 Network Service: Convert port_forwarding_controller.cc to mojo host resolver Bug: 874651 Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d Reviewed-on: https://chromium-review.googlesource.com/1184306 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#585658} [modify] https://crrev.com/8e3e6c835acc68d8962a0beb98ccf866564b82e7/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/8e3e6c835acc68d8962a0beb98ccf866564b82e7/chrome/browser/devtools/device/port_forwarding_controller.h
,
Aug 23
,
Oct 20
,
Oct 20
,
Oct 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/290959673f4e335d0e84443224712af0c2518813 commit 290959673f4e335d0e84443224712af0c2518813 Author: Jun Cai <juncai@chromium.org> Date: Sat Oct 20 02:07:42 2018 Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#601390} [modify] https://crrev.com/290959673f4e335d0e84443224712af0c2518813/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/290959673f4e335d0e84443224712af0c2518813/chrome/browser/devtools/device/port_forwarding_controller.h
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74fd5460d048035f72385d2098d20a0832770469 commit 74fd5460d048035f72385d2098d20a0832770469 Author: Jun Cai <juncai@chromium.org> Date: Mon Oct 22 17:17:08 2018 Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813) Reviewed-on: https://chromium-review.googlesource.com/c/1294192 Cr-Commit-Position: refs/branch-heads/3578@{#221} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/74fd5460d048035f72385d2098d20a0832770469/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/74fd5460d048035f72385d2098d20a0832770469/chrome/browser/devtools/device/port_forwarding_controller.h
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6deffe5b4ec63d84909c05c0270f2101ce40d895 commit 6deffe5b4ec63d84909c05c0270f2101ce40d895 Author: Jun Cai <juncai@chromium.org> Date: Mon Oct 22 19:03:27 2018 Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813) Reviewed-on: https://chromium-review.googlesource.com/c/1294410 Cr-Commit-Position: refs/branch-heads/3538@{#1028} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/6deffe5b4ec63d84909c05c0270f2101ce40d895/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/6deffe5b4ec63d84909c05c0270f2101ce40d895/chrome/browser/devtools/device/port_forwarding_controller.h
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6deffe5b4ec63d84909c05c0270f2101ce40d895 Commit: 6deffe5b4ec63d84909c05c0270f2101ce40d895 Author: juncai@chromium.org Commiter: juncai@chromium.org Date: 2018-10-22 19:03:27 +0000 UTC Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813) Reviewed-on: https://chromium-review.googlesource.com/c/1294410 Cr-Commit-Position: refs/branch-heads/3538@{#1028} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74fd5460d048035f72385d2098d20a0832770469 Commit: 74fd5460d048035f72385d2098d20a0832770469 Author: juncai@chromium.org Commiter: juncai@chromium.org Date: 2018-10-22 17:17:08 +0000 UTC Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813) Reviewed-on: https://chromium-review.googlesource.com/c/1294192 Cr-Commit-Position: refs/branch-heads/3578@{#221} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a312ce969ef219e926aa0c0e87effe7c9a943cb6 commit a312ce969ef219e926aa0c0e87effe7c9a943cb6 Author: Jun Cai <juncai@chromium.org> Date: Wed Oct 31 17:57:04 2018 Reland: Network Service: Convert port_forwarding_controller.cc to mojo host resolver The "Initial upload" patch is the same as the reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1184306 Bug: 874651 , 896603 Change-Id: I406f587cf4b9e69a80fb82e4558a78209eca801c Reviewed-on: https://chromium-review.googlesource.com/c/1294719 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604325} [modify] https://crrev.com/a312ce969ef219e926aa0c0e87effe7c9a943cb6/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/a312ce969ef219e926aa0c0e87effe7c9a943cb6/chrome/browser/devtools/device/port_forwarding_controller.h
,
Oct 31
,
Nov 3
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by dxie@chromium.org
, Aug 15Status: Available (was: InternalsServicesNetworking)