New issue
Advanced search Search tips

Issue 874635 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression
M71

Blocking:
issue 807428



Sign in to add a comment

FormsTestCase fails with slim-navigation-manager

Project Member Reported by danyao@chromium.org, Aug 15

Issue description

Failing tests with --enable-features=SlimNavigationManager:

FormsTestCase/testRepostFormAfterTappingBackAndForward
FormsTestCase/testRepostFormAfterTappingBack
FormsTestCase/testRepostFormCancelling
 
Labels: -Pri-2 M70 Pri-1
Labels: -M70 ReleaseBlock-Stable M71
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceb117a64f4075f419a0429e19f8a43cde99f368

commit ceb117a64f4075f419a0429e19f8a43cde99f368
Author: Danyao Wang <danyao@chromium.org>
Date: Tue Sep 25 16:39:07 2018

[Nav Experiment] Update FormsTestCase setup for WKBasedNavigationManger.

These tests currently assume that the repost confirmation dialog is
shown on back/forward navigation. This is not true for
WKBasedNavigationManager because it matches WKWebView behavior, which
uses back/forward cache for back/forward navigation. This CL adds
|reload| to explicitly trigger the repost confirmation dialog.

Bug:  874635 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I24dafdd02014184f3fbc5b86f1026ebe8f5f00c7
Reviewed-on: https://chromium-review.googlesource.com/1243323
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593965}
[modify] https://crrev.com/ceb117a64f4075f419a0429e19f8a43cde99f368/ios/chrome/browser/web/forms_egtest.mm
[modify] https://crrev.com/ceb117a64f4075f419a0429e19f8a43cde99f368/ios/web/web_state/ui/crw_web_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment