New issue
Advanced search Search tips

Issue 874628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression
M70

Blocking:
issue 807428



Sign in to add a comment

PaymentRequestJourneyLoggerEGTest fails with slim-navigation-manager

Project Member Reported by danyao@chromium.org, Aug 15

Issue description

Failing tests with --enable-features=SlimNavigationManager:

PaymentRequestJourneyLoggerEGTest/testUserHadCompleteSuggestionsForEverything
PaymentRequestJourneyLoggerEGTest/testUserHadIncompleteSuggestionsForEverything_CardNetworkNotSupported
PaymentRequestJourneyLoggerEGTest/testUserHadIncompleteSuggestionsForEverything_NoCard
 
Labels: -Pri-2 M70 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f85a6593faa4608b445f230ae8b035c2fd68ec8a

commit f85a6593faa4608b445f230ae8b035c2fd68ec8a
Author: Danyao Wang <danyao@chromium.org>
Date: Thu Aug 16 14:52:56 2018

[Nav Experiment] Fix PaymentRequestJourneyLoggerEGTest expectations.

Current expectations assume a buggy behavior of LegacyNavigationManager,
which doesn't create a pending item on reload (crbug.com/676129). The
test initiates a navigation to the same page to abort the payment
request. This navigation is incorrectly classified as renderer-initiated
by LegacyNavigationManager, which causes the abort reason for payment
request to be incorrectly logged as EVENT_OTHER_ABORTED.

WKBasedNavigationManager fixes this bug, so the test should now check
EVENT_USER_ABORTED.

Bug:  874628 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I74997df64464f196cfcfb34f21b0252d2f2f6e3e
Reviewed-on: https://chromium-review.googlesource.com/1176470
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583648}
[modify] https://crrev.com/f85a6593faa4608b445f230ae8b035c2fd68ec8a/ios/chrome/browser/ui/payments/payment_request_journey_logger_egtest.mm

Status: Fixed (was: Started)

Sign in to add a comment