New issue
Advanced search Search tips

Issue 874626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Remoting Android] Resize-to-fit on Android

Project Member Reported by yuweih@chromium.org, Aug 15

Issue description

Android client should also support resize-to-fit, so that it is on par with the iOS client.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20f21c7b0cf489bfeba0368322292434725805e6

commit 20f21c7b0cf489bfeba0368322292434725805e6
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Aug 23 01:39:16 2018

[Remoting Android] Support for resizing host to fit client resolution

This CL adds support for Android client to resize host to fit client
resolution.

Bug:  874626 
Change-Id: I9c3c8139eab20834e79deb2ce662a8ab1234b09c
Reviewed-on: https://chromium-review.googlesource.com/1182187
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585358}
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/android/java/res/menu/desktop_actionbar.xml
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/android/java/src/org/chromium/chromoting/Desktop.java
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/android/java/src/org/chromium/chromoting/jni/Client.java
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/client/chromoting_session.cc
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/client/chromoting_session.h
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/client/jni/jni_client.cc
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/client/jni/jni_client.h
[modify] https://crrev.com/20f21c7b0cf489bfeba0368322292434725805e6/remoting/resources/remoting_strings.grd

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43262f95163c64b42ade9755172dc30839f4401c

commit 43262f95163c64b42ade9755172dc30839f4401c
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Aug 24 21:42:09 2018

[Remoting Mobile] Move the minimum portrait resolution checking logic to ChromotingSession

This CL moves the logic of ignoring client resolution of a portrait mode
phone screen into ChromotingSession, so that the Android client can get
this for free.

Bug:  874626 
Change-Id: I0bf946c8a2ba5ce52e70b54b06517a3334f5727e
Reviewed-on: https://chromium-review.googlesource.com/1187802
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586001}
[modify] https://crrev.com/43262f95163c64b42ade9755172dc30839f4401c/remoting/client/chromoting_session.cc
[modify] https://crrev.com/43262f95163c64b42ade9755172dc30839f4401c/remoting/ios/app/host_view_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment