New issue
Advanced search Search tips

Issue 874625 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Show issue message as sink button status text

Project Member Reported by taku...@chromium.org, Aug 15

Issue description

Per the new mocks (internal [1]), when there is an issue, the message should be shown in the status text label.

[1] https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZYjt3WjXRILg/files/MCHtA7U1iMGr64QMm_KU_NkSTtXe0pqijKE
 
Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9ecd1782b1930e0e55e164431fa888b1f048389

commit c9ecd1782b1930e0e55e164431fa888b1f048389
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Aug 16 00:24:43 2018

[Harmony Cast Dialog] Show issue text in sink button

If there is an issue associated with a sink, use the issue text as the
status text for the sink.

Bug:  874625 
Change-Id: I2dd844a851cc58828047dd3305b3fd729ba514e0
Reviewed-on: https://chromium-review.googlesource.com/1176473
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583459}
[modify] https://crrev.com/c9ecd1782b1930e0e55e164431fa888b1f048389/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc

Sign in to add a comment