New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874611 link

Starred by 1 user
Status: Fixed
Owner:
█ sonnysasaka@chromium.org
Last visit > 30 days ago
Closed: Sep 5
Cc:
snanda@chromium.org
█ sonnysasaka@chromium.org
█ dmitrygr@chromium.org
█ mcchou@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Refine ChipLost2 metrcis

Project Member Reported by mcchou@chromium.org, Aug 15 
This tracks the progress of introducing a listener to powerd in BlueZ for refining the BlueZ.ChipLost2 UMA metrics.

Although PauseDiscovery/UnpauseDiscovery should get called whenever there are system suspends/resumes, we should not depend on BT dispatcher to do the right thing. Instead, we should listen to powerd directly.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2c9fc89821d84cad8dd181a47dc36d7dede8ebfb

commit 2c9fc89821d84cad8dd181a47dc36d7dede8ebfb
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Fri Aug 24 00:42:50 2018

bluetooth: Add parameter to PauseDiscovery and UnpauseDiscovery

PauseDiscovery and UnpauseDiscovery are going to be used by multiple
clients and not all requests are related to system suspend/resume.
Therefore a parameter is needed for clients to indicate whether the
request is related to system suspend/resume, which in turn affects how
bluetoothd records metrics for chip lost (ignore if adapter is gone
during suspend/resume).

BUG= chromium:874611 ,chromium:523176
TEST=Tested with the modified bluetoothd
CQ-DEPEND=CL:1184151

Change-Id: I61363c9b80ea49cc32b269f67b20252487014815
Reviewed-on: https://chromium-review.googlesource.com/1184154
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Qiyu Hu <qiyuh@chromium.org>

[modify] https://crrev.com/2c9fc89821d84cad8dd181a47dc36d7dede8ebfb/bluetooth/dispatcher/suspend_manager.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

Labels: merge-merged-chromeos-5.44
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/bluez/+/737a1288408c6c2e598b99d2450cb22c96b7ef00

commit 737a1288408c6c2e598b99d2450cb22c96b7ef00
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Fri Aug 24 00:42:50 2018

CHROMIUM: Add parameter to PauseDiscovery and UnpauseDiscovery

PauseDiscovery and UnpauseDiscovery are going to be used by multiple
clients and not all requests are related to system suspend/resume.
Therefore a parameter is needed for clients to indicate whether the
request is related to system suspend/resume, which in turn affects how
bluetoothd records metrics for chip lost (ignore if adapter is gone
during suspend/resume).

BUG= chromium:874611 ,chromium:523176
TEST=Tested with the modified btdispatch
CQ-DEPEND=CL:1184154

Change-Id: I1b1933b2bc69e8d3132e7847a983847d78793fcd
Reviewed-on: https://chromium-review.googlesource.com/1184151
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Qiyu Hu <qiyuh@chromium.org>

[modify] https://crrev.com/737a1288408c6c2e598b99d2450cb22c96b7ef00/doc/adapter-api.txt
[modify] https://crrev.com/737a1288408c6c2e598b99d2450cb22c96b7ef00/src/adapter.c

Comment 3 by sonnysasaka@chromium.org, Sep 5

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/de679fe1c361ca3b54cbb2907d66b95787e1f4cb

commit de679fe1c361ca3b54cbb2907d66b95787e1f4cb
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Wed Sep 05 00:34:26 2018

bluetooth: Add parameter to PauseDiscovery and UnpauseDiscovery

PauseDiscovery and UnpauseDiscovery are going to be used by multiple
clients and not all requests are related to system suspend/resume.
Therefore a parameter is needed for clients to indicate whether the
request is related to system suspend/resume, which in turn affects how
bluetoothd records metrics for chip lost (ignore if adapter is gone
during suspend/resume).

BUG= chromium:874611 ,chromium:523176
TEST=Tested with the modified bluetoothd
CQ-DEPEND=CL:1184151

Change-Id: I61363c9b80ea49cc32b269f67b20252487014815
Reviewed-on: https://chromium-review.googlesource.com/1184154
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Qiyu Hu <qiyuh@chromium.org>
(cherry picked from commit 2c9fc89821d84cad8dd181a47dc36d7dede8ebfb)
Reviewed-on: https://chromium-review.googlesource.com/1205471
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>

[modify] https://crrev.com/de679fe1c361ca3b54cbb2907d66b95787e1f4cb/bluetooth/dispatcher/suspend_manager.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/bluez/+/38f7a9e318c1aeb9d22212f7306c054d198961d0

commit 38f7a9e318c1aeb9d22212f7306c054d198961d0
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Wed Sep 05 00:34:26 2018

CHROMIUM: Add parameter to PauseDiscovery and UnpauseDiscovery

PauseDiscovery and UnpauseDiscovery are going to be used by multiple
clients and not all requests are related to system suspend/resume.
Therefore a parameter is needed for clients to indicate whether the
request is related to system suspend/resume, which in turn affects how
bluetoothd records metrics for chip lost (ignore if adapter is gone
during suspend/resume).

BUG= chromium:874611 ,chromium:523176
TEST=Tested with the modified btdispatch
CQ-DEPEND=CL:1184154

Change-Id: I1b1933b2bc69e8d3132e7847a983847d78793fcd
Reviewed-on: https://chromium-review.googlesource.com/1184151
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Qiyu Hu <qiyuh@chromium.org>
(cherry picked from commit 737a1288408c6c2e598b99d2450cb22c96b7ef00)
Reviewed-on: https://chromium-review.googlesource.com/1205637
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Qiyu Hu <qiyuh@google.com>
Commit-Queue: Qiyu Hu <qiyuh@google.com>

[modify] https://crrev.com/38f7a9e318c1aeb9d22212f7306c054d198961d0/doc/adapter-api.txt
[modify] https://crrev.com/38f7a9e318c1aeb9d22212f7306c054d198961d0/src/adapter.c
►

Sign in to add a comment