New issue
Advanced search Search tips

Issue 874609 link

Starred by 3 users
Status: Fixed
Owner:
jkardatzke@chromium.org
Closed: Aug 20
Cc:
smbar...@chromium.org
dgreid@chromium.org
tbuck...@chromium.org
saintlou@google.com
josa...@google.com
puneetster@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

Opening Chrome URLs from container no longer works

Project Member Reported by jkardatzke@chromium.org, Aug 15 
After the gRPC functionality was changed to use vsock, the static calls in garcon were not fixed to account for this and still try to connect with IPv4.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/422006376be0524fc1ac7d391b8547e3b8afdb53

commit 422006376be0524fc1ac7d391b8547e3b8afdb53
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Thu Aug 16 20:14:55 2018

vm_tools: garcon: Fix regression for opening URLs in Chrome

This fixes a bug where we didn't update the OpenUrl and
OpenTerminal calls to use the vsock port.

BUG= chromium:874609 
TEST=Verified on eve that urls and terminals can open

Change-Id: I780449e6f5618f40ee58e0f332a35593b14fe2ae
Reviewed-on: https://chromium-review.googlesource.com/1176468
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/422006376be0524fc1ac7d391b8547e3b8afdb53/vm_tools/garcon/host_notifier.cc

Comment 2 by jkardatzke@chromium.org, Aug 16

Labels: Merge-Request-69
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 16

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by smbar...@chromium.org, Aug 17 

Fix is verified on component version 10975.0.0

Comment 5 by cindyb@chromium.org, Aug 20

Labels: -Merge-Review-69 M-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 20

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f95f40127f2e219398dba9967e881fba9d1f19df

commit f95f40127f2e219398dba9967e881fba9d1f19df
Author: Jeffrey Kardatzke <jkardatzke@google.com>
Date: Mon Aug 20 17:52:56 2018

vm_tools: garcon: Fix regression for opening URLs in Chrome

This fixes a bug where we didn't update the OpenUrl and
OpenTerminal calls to use the vsock port.

BUG= chromium:874609 
TEST=Verified on eve that urls and terminals can open

Change-Id: I5d43fdc4624665f4600041813882acda494b49ed
Reviewed-on: https://chromium-review.googlesource.com/1181652
Commit-Queue: J Kardatzke <jkardatzke@chromium.org>
Tested-by: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/f95f40127f2e219398dba9967e881fba9d1f19df/vm_tools/garcon/host_notifier.cc

Comment 7 by jkardatzke@chromium.org, Aug 20

Labels: -Merge-Approved-69 Merge-Merged
Status: Fixed (was: Started)
►

Sign in to add a comment