New issue
Advanced search Search tips

Issue 874596 link

Starred by 0 users

Issue metadata

Status: Duplicate
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Splitview to home launcher transition is strange.

Project Member Reported by sammiequon@chromium.org, Aug 15

Issue description

With either one snap or both snap splitview, pressing the home launcher button results in a window trying to animate to fill, then suddenly doing the minimize animation. This looks jarring and we should find a more smooth way. But for now we should skip the animate to fill and just minimize as a quick solution.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18d495442a635a8eb397e0705f1270d0448d47d2

commit 18d495442a635a8eb397e0705f1270d0448d47d2
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Aug 21 18:22:23 2018

splitview: Do not maximize windows when exiting to home launcher.

Instead minimize them. UX has some ideas for a nicer looking animation,
but for M70 this is a good stop gap because it prevents a maximize
animation starting then a minimize animation occuring halfway.

Test: added test and manual
Bug:  874596 
Change-Id: I4a7ddfe31bb76f0d7a636c15baf4be0c04121a46
Reviewed-on: https://chromium-review.googlesource.com/1180075
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584839}
[modify] https://crrev.com/18d495442a635a8eb397e0705f1270d0448d47d2/ash/shelf/app_list_shelf_item_delegate.cc
[modify] https://crrev.com/18d495442a635a8eb397e0705f1270d0448d47d2/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/18d495442a635a8eb397e0705f1270d0448d47d2/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/18d495442a635a8eb397e0705f1270d0448d47d2/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/18d495442a635a8eb397e0705f1270d0448d47d2/ash/wm/tablet_mode/tablet_mode_window_manager.cc

Cc: -mccanny@chromium.org sammiequon@chromium.org
Labels: -Pri-2 Pri-3
Owner: mccanny@chromium.org
#1 fixes it for now so you dont have a overlapping minimize/maximize animations.

Assign to Ben for future work, or to close if its good enough.
Labels: Not-Touch-Friendly-Launcher
Labels: -M-70 M-71
Labels: -M-71
Mergedinto: 871974
Status: Duplicate (was: Assigned)

Sign in to add a comment