Export symbols from libraries required by feature modules |
||||||
Issue descriptionTo support a VR UI native code module, methods from base, skia and other libraries must be exported, the same way they are for component builds. In order to minimize the impact on APK size, the build will dynamically generate a linker script that will hide unneeded methods at link time.
,
Aug 22
,
Aug 22
,
Aug 22
,
Aug 23
In addition to the initial batch of export header adjustments, the following is necessary: - Edits to the vector icon header macros and/or some vector icon sets to export those symbols. - A change within the Skia repo to land the FEATURE_MODULES conditionals there.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9 commit fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9 Author: Christopher Grant <cjgrant@chromium.org> Date: Tue Sep 04 17:41:42 2018 Allow vector icons to be exported for use by feature modules. If the feature is enabled, this change allows a subset of vector icons to be visible, such that the linker can expose them to libraries outside the base .so. Bug: 874583 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I01276a566efc189fd7ce2cf9082eef90ec59773f Reviewed-on: https://chromium-review.googlesource.com/1197354 Reviewed-by: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#588578} [modify] https://crrev.com/fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9/chrome/browser/vr/vector_icons/BUILD.gn [modify] https://crrev.com/fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9/chrome/browser/vr/vector_icons/vector_icons.cc.template [modify] https://crrev.com/fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9/chrome/browser/vr/vector_icons/vector_icons.h.template [modify] https://crrev.com/fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9/components/vector_icons/BUILD.gn [modify] https://crrev.com/fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9/components/vector_icons/cc_macros.h [modify] https://crrev.com/fb1cbb9d8c62ff928a560dd3718f3f1b6fde36f9/components/vector_icons/vector_icons.h.template
,
Jan 3
,
Jan 14
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 Deleted