New issue
Advanced search Search tips

Issue 874560 link

Starred by 2 users
Status: Fixed
Owner:
pkasting@chromium.org
Closed: Aug 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
M-X

Blocking:
issue 841643



Sign in to add a comment

Remove low contrast stroke for single-tab mode

Project Member Reported by bettes@chromium.org, Aug 15 
Issue 848546 draws a stroke around toolbar and active tab when contrast is low. We should disable this effect for single tab mode.

Comment 1 by bettes@chromium.org, Aug 15

Screen Shot 2018-08-15 at 1.13.31 PM.png
84.2 KB View Download

Comment 2 by meh...@chromium.org, Aug 15

Cc: pkasting@chromium.org

Comment 3 by pkasting@chromium.org, Aug 16 

Yeah, true

Comment 4 by pkasting@chromium.org, Aug 22

Cc: -pkasting@chromium.org
Owner: pkasting@chromium.org
Status: Started (was: Available)
This turned out to be trivial, so...
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6447201a2bcd58ae10d04eef4d6eef0483572e0

commit c6447201a2bcd58ae10d04eef4d6eef0483572e0
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Aug 22 04:03:51 2018

Don't draw a stroke in single-tab mode.

Bug:  874560 
Test: Run chrome with --enable-features=SingleTabMode, there should be no stroke around the (one) tab.
Change-Id: I002f058478c46ca68942e55c3bad8c1376f231fb
Reviewed-on: https://chromium-review.googlesource.com/1184378
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584957}
[modify] https://crrev.com/c6447201a2bcd58ae10d04eef4d6eef0483572e0/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc

Comment 6 by pkasting@chromium.org, Aug 22

Status: Fixed (was: Started)

Comment 7 by krajshree@chromium.org, Aug 24

Labels: TE-Verified-M70 TE-Verified-70.0.3532.0
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix.

Verified the fix on Mac 10.13.3, win-10 and ubuntu 17.10 using latest chrome version #70.0.3532.0 as per the comment #0, #1 and #5.
Attaching screen shot for reference.
Observed that a stroke is not drawn in single-tab mode.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
Screen Shot 2018-08-24 at 17.04.05.png
271 KB View Download
►

Sign in to add a comment