New issue
Advanced search Search tips

Issue 874538 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ChromeLauncherControllerWithArcTest.ArcCustomAppIcon is flaky

Project Member Reported by xidac...@chromium.org, Aug 15

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5df8ae571437b397de2f392f14bcf4b5be58ad81

commit 5df8ae571437b397de2f392f14bcf4b5be58ad81
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Aug 15 18:53:48 2018

Disable ChromeLauncherControllerWithArcTest.ArcCustomAppIcon

It has been flaky for a while

TBR=wjmaclean@chromium.org
NOTRY=true

Bug:  874538 
Change-Id: Ia598f4367f0d90ff407395ffe69fb96ed707b59c
Reviewed-on: https://chromium-review.googlesource.com/1176208
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583343}
[modify] https://crrev.com/5df8ae571437b397de2f392f14bcf4b5be58ad81/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Labels: -Pri-3 Pri-2
Components: UI>Shell>Shelf
Issue 873722 has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad543317c5d73372b967a6dc1cba9f586f4df708

commit ad543317c5d73372b967a6dc1cba9f586f4df708
Author: khmel@google.com <khmel@google.com>
Date: Thu Aug 23 16:35:26 2018

shelf: fix ArcCustomAppIcon flakiness.

This resolves races in this test.

TEST=Passes ~10000 iteration, no failure reported (before ~5%)
BUG= 874538 

Change-Id: I4d098ebc9a3bb76af3d640a0336716a9b570a2a3
Reviewed-on: https://chromium-review.googlesource.com/1186548
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585511}
[modify] https://crrev.com/ad543317c5d73372b967a6dc1cba9f586f4df708/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment