New issue
Advanced search Search tips

Issue 874534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 874471



Sign in to add a comment

[CRD iOS] MDCAppBar -> MDCAppBarViewController migration

Project Member Reported by yuweih@chromium.org, Aug 15

Issue description

MDCAppBar is being deprecated. See bug 874471 for more details.
 
Blocking: 874471
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb461febc43be45e90eedda0c8f2d43438e0b49

commit bfb461febc43be45e90eedda0c8f2d43438e0b49
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Aug 24 23:15:34 2018

[CRD iOS] Migrate MDCAppBar to MDCAppBarViewController

MDCAppBar will soon be deprecated. This CL migrates all MDCAppBar code
to use MDCAppBarViewController.

It is basically following the migration guide here:
https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller

Bug:  874534 
Change-Id: Ibe3ea272763b98bd7ded513111167221f06c9e6b
Reviewed-on: https://chromium-review.googlesource.com/1187402
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586042}
[modify] https://crrev.com/bfb461febc43be45e90eedda0c8f2d43438e0b49/remoting/ios/app/remoting_menu_view_controller.mm
[modify] https://crrev.com/bfb461febc43be45e90eedda0c8f2d43438e0b49/remoting/ios/app/remoting_view_controller.mm
[modify] https://crrev.com/bfb461febc43be45e90eedda0c8f2d43438e0b49/remoting/ios/app/settings/remoting_settings_view_controller.mm

Status: Fixed (was: Assigned)
Labels: -M-72 M-70

Sign in to add a comment