New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874518 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 21
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Arrow key autocomplete behavior

Project Member Reported by oxyflush@chromium.org, Aug 15

Issue description

How should arrow keys behave in the autocomplete feature?
 
Discussed offline:

Arrow keys should not autocomplete until further notice.
Cc: ginko@chromium.org
Currently pressing the 'down' arrow will solidify the autocomplete, and modify the results you were attempting to go through.

Does this bug cover fixing that?
Yes, it will.
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55b298b37b149a161c1643fc40b5dccb377d4a52

commit 55b298b37b149a161c1643fc40b5dccb377d4a52
Author: Daniel Zhang <oxyflush@google.com>
Date: Tue Aug 21 18:20:11 2018

cros: Remove AppList arrow key autocomplete.

Removing the completion of an autocomplete
suggestion with the arrow keys until further
UX input. Also updated tests and current code
to reflect this.

Bug:  874518 
Change-Id: I2d35799b8b50e93b466c82e7fba9c5c523e9bef8
Reviewed-on: https://chromium-review.googlesource.com/1180100
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584835}
[modify] https://crrev.com/55b298b37b149a161c1643fc40b5dccb377d4a52/ash/app_list/views/search_box_view.cc
[modify] https://crrev.com/55b298b37b149a161c1643fc40b5dccb377d4a52/ash/app_list/views/search_box_view_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on M-71 (11151.11.0, 71.0.3578.21).

Sign in to add a comment