crostini tablet mode handles menus/modal dialogs poorly |
|||||||
Issue descriptionI see two issues that are mildly related: 1) On X11 apps like Firefox, menus are often implemented as X11 windows. In laptop mode, sommelier makes its best effort and places the window in the right spot. In tablet mode, the menu is always placed in the dead center of the screen. See firefox.webm. 2) On GTK3 apps opening modal dialogs, Chrome attempts to maximize the dialog. The app doesn't want this dialog to take the full screen, which causes a weird rubberbanding effect. See polari.webm.
,
Aug 15
,
Aug 16
,
Aug 23
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcb68779ca1d34cb992653cc880b95476c5b4055 commit bcb68779ca1d34cb992653cc880b95476c5b4055 Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Aug 27 22:52:54 2018 X11 override redirect window should not be managed by WindowManager. * Sommelier sets the null application id for override redirect window. Menu should have a parent, so use both conditions to treat it as a menu window. Do not maximize the transient window because it's used for dialog windows. (they will be centered). I also added check if the bounds change should animate. This is already done in clamshell, and this should mitigate weird behavior even if there is a window that doesn't match this condition. Bug: 874516 Test: covered by unittest. also tested manually. see bug for repro step. Change-Id: Ie318c3e594839f1cfec8bdc6b3f4810eba248d85 Reviewed-on: https://chromium-review.googlesource.com/1188894 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#586465} [modify] https://crrev.com/bcb68779ca1d34cb992653cc880b95476c5b4055/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc [modify] https://crrev.com/bcb68779ca1d34cb992653cc880b95476c5b4055/ash/wm/tablet_mode/tablet_mode_window_state.cc [modify] https://crrev.com/bcb68779ca1d34cb992653cc880b95476c5b4055/components/exo/shell_surface.cc [modify] https://crrev.com/bcb68779ca1d34cb992653cc880b95476c5b4055/components/exo/shell_surface_unittest.cc
,
Aug 27
,
Oct 3
oshima@ Can you please provide steps to install firefox for verifying the bug. Thanks!
,
Oct 3
https://www.reddit.com/r/Crostini/wiki/howto/install-firefox-quantum I used Flatpak method.
,
Oct 8
Verified using polari on eve on 11137.0.0, 71.0.3567.0 in tablet mode. I'm finding some issues while installing firefox, I'll file separate bug if required. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by reve...@chromium.org
, Aug 15