New issue
Advanced search Search tips

Issue 874510 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-04
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fling browser window into overview in tablet mode

Project Member Reported by minch@chromium.org, Aug 15

Issue description

Fling a browser window in non-tab area of title bar should able to drop it into overview once the velocity exceed the threshold. Just the same as fling an app window from top.
 
Labels: Tablet-Polish
Labels: -Pri-2 Pri-1
Labels: -M-70 M-71
This is a P1 for Tablet.  Do we have an ETA for this landing?
Will work on it this week.
NextAction: 2018-10-04
Status: Started (was: Assigned)
The NextAction date has arrived: 2018-10-04
This is expected to land before branch per xdai@.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd378ab0c87137084e445ed6f6498c56b34e4082

commit dd378ab0c87137084e445ed6f6498c56b34e4082
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Sat Oct 06 00:36:11 2018

Move fling/swipe event handling logic to WindowResizer.

It's needed for  crbug.com/874510 .
Since we have different WindowResizer for laptop mode and tablet mode,
and they will have different behavior for fling/swipe events, we should
let WindowResizer to do the fling/swipe event handling. So move the
logic to WindowResizer.

No functionality is changed in this CL. I'll add special logic for
tablet mode window fling/swipe in a following-up CL.

Bug:  874510 
Change-Id: I91b917e8ec947681db12d5be8b8c8b982299af9a
Reviewed-on: https://chromium-review.googlesource.com/c/1262457
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597380}
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/default_window_resizer.cc
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/default_window_resizer.h
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/drag_window_resizer.cc
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/drag_window_resizer.h
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/tablet_mode/tablet_mode_browser_window_drag_controller.cc
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/tablet_mode/tablet_mode_browser_window_drag_controller.h
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/window_resizer.h
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/wm_toplevel_window_event_handler.cc
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/wm_toplevel_window_event_handler.h
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/dd378ab0c87137084e445ed6f6498c56b34e4082/ash/wm/workspace/workspace_window_resizer.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0bd48fdf26a5facddf843f0befb3c260711ece0

commit c0bd48fdf26a5facddf843f0befb3c260711ece0
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Oct 08 22:02:29 2018

Implement browser window fling event in tablet mode.

When fling event happens on the caption area of a browser window, it
should have the same behavior as flinging on an app window.

Bug:  874510 
Change-Id: I86c33cd52cac134ccadec5673ec9b3066c8305a6
Reviewed-on: https://chromium-review.googlesource.com/c/1268665
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597696}
[modify] https://crrev.com/c0bd48fdf26a5facddf843f0befb3c260711ece0/ash/BUILD.gn
[modify] https://crrev.com/c0bd48fdf26a5facddf843f0befb3c260711ece0/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/c0bd48fdf26a5facddf843f0befb3c260711ece0/ash/wm/tablet_mode/tablet_mode_app_window_drag_controller.cc
[modify] https://crrev.com/c0bd48fdf26a5facddf843f0befb3c260711ece0/ash/wm/tablet_mode/tablet_mode_app_window_drag_controller.h
[modify] https://crrev.com/c0bd48fdf26a5facddf843f0befb3c260711ece0/ash/wm/tablet_mode/tablet_mode_browser_window_drag_controller.cc
[modify] https://crrev.com/c0bd48fdf26a5facddf843f0befb3c260711ece0/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc
[modify] https://crrev.com/c0bd48fdf26a5facddf843f0befb3c260711ece0/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.h
[modify] https://crrev.com/c0bd48fdf26a5facddf843f0befb3c260711ece0/components/exo/client_controlled_shell_surface_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment