Restore the dragged window to its original state or drop it into overview based on its current position |
||
Issue descriptionDrag a window from top in tablet mode, its transform will be changed during drag. and a minimum transform will be kept once it has been dragged further than a threshold y position (e.g, the y position of the new selector item) Let's say the window's original y position is Y0, and the threshold y position is Y1. Then, the middle value of drag distance will be Y_mid = (Y1 - Y0) / 2.0 After release the drag, 1. Restore the drag window back to its original state (maximized/fullscreened/snapped) if it has been dragged shorter than Y_mid; 2. Drop the drag window into overview if has been dragged further than Y_mid;
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e6ef9067222d6770a334278b143e3a7aa9df047 commit 8e6ef9067222d6770a334278b143e3a7aa9df047 Author: Min Chen <minch@google.com> Date: Wed Aug 29 18:58:46 2018 Drop the dragged window into overview on drag position. Drop the dragged window into overview if the window has been dragged further than half of the distance from top of the display to the top of the new selector item in overview. Do not apply this rule if preview area is shown or splitview is active. Bug: 874508 Change-Id: Ib3faf6aadd8a49f2380b330fddd1b647bf63a9e7 Reviewed-on: https://chromium-review.googlesource.com/1192699 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#587224} [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/overview/window_grid.cc [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/overview/window_grid.h [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/overview/window_selector.cc [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/overview/window_selector.h [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc [modify] https://crrev.com/8e6ef9067222d6770a334278b143e3a7aa9df047/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.h
,
Aug 29
|
||
►
Sign in to add a comment |
||
Comment 1 by minch@chromium.org
, Aug 28