New issue
Advanced search Search tips

Issue 874489 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 681067
issue 874490



Sign in to add a comment

Update usage of IsAshInBrowserProcess in content

Project Member Reported by sky@chromium.org, Aug 15

Issue description

Specifically we need to look at each usage and decide whether it equally applies to single-process-mash or not. If it applies to both, then convert it to IsUsingWindowService(). This is a good opportunity to ensure we have bugs files for all usages that need updating as well.
 
Blocking: 874490
Blocking: 681067
Actually, maybe this isn't necessary. Let me investigate.
Labels: OS-Chrome
Status: Started (was: Assigned)
I'm wrong, this is needed.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49d2db6b66f5c270fb0c3354a163d1f3125541b8

commit 49d2db6b66f5c270fb0c3354a163d1f3125541b8
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 16 19:28:08 2018

chromeos: fixs conditionals for single-process-mash

For the most part this converts IsAshInBrowserProcess() to
IsUsingWindowService(). There are a couple of exceptions, mostly around
startup.

BUG= 874489 
TEST=covered by tests

Change-Id: I55f99fd3c96e6605a672257304fe96a8cd2829cc
Reviewed-on: https://chromium-review.googlesource.com/1176641
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583771}
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/ash/shell.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/ash/ws/window_service_owner.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/browser_main_loop.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/oop_browsertest.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/service_manager/common_browser_interfaces.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/common/content_param_traits.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/49d2db6b66f5c270fb0c3354a163d1f3125541b8/content/renderer/render_widget.cc

Status: Fixed (was: Started)

Sign in to add a comment