New issue
Advanced search Search tips

Issue 874487 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

check_json_from_yaml.sh has weird behavior

Project Member Reported by jettrink@chromium.org, Aug 15

Issue description

1) This requires `repo upload` to be run from chroot (otherwise it asks for sudo password and still fails). This is definitely inconvenient.

2) This script has different behavior based on whether I have started cros_work
 - I typically do not start cros_work on when I am changing the model.yaml file. If that is the case, then the generated output does not line up with my changes.

3) The script does not ensure that the auto_generated file with the "correct checksum" (see point 2) is actually in your commit (instead of just your working directory)

 
Cc: gmeinke@chromium.org
Owner: shapiroc@chromium.org
Status: Assigned (was: Untriaged)
Thanks for the feedback.

Arch wasn't ideal.  Potentially I'll put the ideas around this in a doc and float it for review.
Thanks!
Status: Fixed (was: Assigned)

Sign in to add a comment