check_json_from_yaml.sh has weird behavior |
|||
Issue description1) This requires `repo upload` to be run from chroot (otherwise it asks for sudo password and still fails). This is definitely inconvenient. 2) This script has different behavior based on whether I have started cros_work - I typically do not start cros_work on when I am changing the model.yaml file. If that is the case, then the generated output does not line up with my changes. 3) The script does not ensure that the auto_generated file with the "correct checksum" (see point 2) is actually in your commit (instead of just your working directory)
,
Aug 16
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-octopus-private/+/b061af53b26bfd931a13c6bf5a640dba6904cd86 commit b061af53b26bfd931a13c6bf5a640dba6904cd86 Author: Jett Rink <jettrink@chromium.org> Date: Thu Aug 16 03:36:15 2018
,
Sep 4
Thanks for the feedback. Arch wasn't ideal. Potentially I'll put the ideas around this in a doc and float it for review.
,
Sep 4
Thanks!
,
Jan 11
|
|||
►
Sign in to add a comment |
|||
Comment 1 by la...@chromium.org
, Aug 15Owner: shapiroc@chromium.org