New issue
Advanced search Search tips

Issue 874485 link

Starred by 0 users
Status: Fixed
Owner:
johnchen@chromium.org
Closed: Aug 15
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for ChromeDriver whitelisted-ips option bug fix

Project Member Reported by johnchen@chromium.org, Aug 15 
Requesting merge of https://chromium-review.googlesource.com/1175059 to m69 branch. This CL fixes a ChromeDriver bug that prevented ChromeDriver from starting on Mac when the --whitelisted-ips option is used on command line. This fix was originally done under  issue chromedriver:2541 .

Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 15

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by gov...@chromium.org, Aug 15

Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #0. Please merge ASAP. Thank you.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc3abe3cf3e418482986cd6f2bca2bd32affb710

commit dc3abe3cf3e418482986cd6f2bca2bd32affb710
Author: John Chen <johnchen@chromium.org>
Date: Wed Aug 15 17:36:10 2018

[ChromeDriver] Fix --whitelisted-ips on Mac

ChromeDriver was not starting successfully on Mac when --whitelisted-ips
option was used. This CL fixes it, while ensuring that ChromeDriver
always listen on the same IPv4 and IPv6 ports

Bug:  874485 ,  chromedriver:2541 
Change-Id: I2024e3c27ea0fcf262c7b5c54791b86ae6a3e0c1
Reviewed-on: https://chromium-review.googlesource.com/1175059
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583085}(cherry picked from commit 147ceb36a481562e46da00b17dd6e1d5d9ab251b)
Reviewed-on: https://chromium-review.googlesource.com/1175467
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#644}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/dc3abe3cf3e418482986cd6f2bca2bd32affb710/chrome/test/chromedriver/server/chromedriver_server.cc

Comment 4 by johnchen@chromium.org, Aug 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment