New issue
Advanced search Search tips

Issue 874481 link

Starred by 1 user
Status: Fixed
Owner:
sky@chromium.org
Closed: Aug 22
Cc:
sadrul@chromium.org
jamescook@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Get MouseWatcher and EventMonitor working with single-process-mash

Project Member Reported by sky@chromium.org, Aug 15 
MouseWatcher makes use of EventMonitor. EventMonitorAura uses a pre-target-handler added to Env::GetInstance(). In single-process-mash mode this won't work from the ash side. We'll need to ensure the right Env is obtained. Further we need to make sure both of these will work correctly in multi-process-mash too.

This code is used from MultiWindowResizeController in ash, and in particular MultiWindowResizeControllerTest.ClickOutside exercises this.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96787ed3ba67e76733a0e2227f93918140c9342

commit d96787ed3ba67e76733a0e2227f93918140c9342
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 15 17:06:18 2018

chromeos: disables MultiWindowResizeControllerTest.ClickOutside

This fails in single-process mash mode because it uses EventMonitorAura,
which uses Env::GetInstance().

BUG= 874481 
TEST=test only change

Change-Id: I1f71b68db1a1b52c8e1c2ecc6c87828eea131700
Reviewed-on: https://chromium-review.googlesource.com/1176067
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583286}
[modify] https://crrev.com/d96787ed3ba67e76733a0e2227f93918140c9342/ash/wm/workspace/multi_window_resize_controller_unittest.cc

Comment 2 by sky@chromium.org, Aug 15

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ac2ec49e7aa23f53e5d0a04728577de830b01f

commit 56ac2ec49e7aa23f53e5d0a04728577de830b01f
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 22 03:30:26 2018

views: gets MouseWatcher/EventMonitor working with two envs

EventMonitor makes use of Env for screen coordinates. In SingleProcessAsh there
will be two Envs, which means EventMonitor needs to know which Env to ask. This
injects a NativeWindow so that the right Env can be used.

This also updates Widget::SynthesizeMouseMoveEvent() appropriately.

BUG= 874481 
TEST=covered by test

Change-Id: If2deb18e06950ab056bc3f3339a0676784d7deae
Reviewed-on: https://chromium-review.googlesource.com/1183883
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584954}
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ash/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ash/wm/workspace/multi_window_resize_controller_unittest.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/bubble/tooltip_icon.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/event_monitor.h
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/event_monitor_aura.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/event_monitor_aura.h
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/event_monitor_mac.h
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/event_monitor_mac.mm
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/event_monitor_unittest.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/mouse_watcher.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/mouse_watcher.h
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/widget/widget.cc
[modify] https://crrev.com/56ac2ec49e7aa23f53e5d0a04728577de830b01f/ui/views/widget/widget_unittest.cc

Comment 4 by sky@chromium.org, Aug 22

Status: Fixed (was: Started)

Comment 5 by sky@chromium.org, Aug 22

Cc: sadrul@chromium.org jamescook@chromium.org
 Issue 603743  has been merged into this issue.
►

Sign in to add a comment