New issue
Advanced search Search tips

Issue 874468 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Aug 24
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 681067
issue 874490



Sign in to add a comment

Update usage of IsAshInBrowserProcess in chrome

Project Member Reported by sky@chromium.org, Aug 15 
Specifically we need to look at each usage and decide whether it equally applies to single-process-mash or not. If it applies to both, then convert it to IsUsingWindowService(). This is a good opportunity to ensure we have bugs files for all usages that need updating as well.

Comment 1 by sky@chromium.org, Aug 15

Blocking: 874490

Comment 2 by sky@chromium.org, Aug 15

Blocking: 681067

Comment 3 by jamescook@chromium.org, Aug 17

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e0c025cf227411c0ae3afc7a1552241c4785797

commit 1e0c025cf227411c0ae3afc7a1552241c4785797
Author: James Cook <jamescook@chromium.org>
Date: Tue Aug 21 02:54:14 2018

chromeos: Cleanup some usage of IsAshInBrowserProcess

We need to distinguish between MultiProcessMash, SingleProcessMash and
both (aka IsUsingWindowService). Clean up some usage in login and
accessibility.

Bug:  874468 
Change-Id: Ibf9694f45114491bf54b232a906b6a5a390e3f05
Reviewed-on: https://chromium-review.googlesource.com/1180344
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584613}
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/ash_service_registry.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/chromeos/accessibility/accessibility_panel.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/chromeos/login/ui/input_events_blocker.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/chromeos/login/ui/login_display_host_common.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/ui/base/ui_base_features.cc
[modify] https://crrev.com/1e0c025cf227411c0ae3afc7a1552241c4785797/ui/base/ui_base_features.h
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8160d033c95d40aa3ae0abbafb1459d8858f06a7

commit 8160d033c95d40aa3ae0abbafb1459d8858f06a7
Author: James Cook <jamescook@chromium.org>
Date: Tue Aug 21 16:02:32 2018

chromeos: Cleanup more usage of IsAshInBrowserProcess

We need to distinguish between MultiProcessMash, SingleProcessMash and
both (aka IsUsingWindowService). Clean up some usage in accessibility,
ARC++, input methods, and virtual keyboard.

Bug:  874468 
Change-Id: I10411268d1e75a21002a95cdb38f01ee78c41061
Reviewed-on: https://chromium-review.googlesource.com/1182452
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584762}
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/ash/shell.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/accessibility/accessibility_extension_api.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/accessibility/accessibility_extension_api_browsertest.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chrome_content_browser_client_browsertest_chromeos.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/arc/video/gpu_arc_video_service_host.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/display/output_protection_delegate.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/input_method/input_method_engine.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/chromeos/system_logs/touch_log_source.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/ui/views/screen_capture_notification_ui_views.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/8160d033c95d40aa3ae0abbafb1459d8858f06a7/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a

commit 913f1641f753a2a10c0dfc3bbfc0ae345474ef3a
Author: James Cook <jamescook@chromium.org>
Date: Tue Aug 21 22:26:13 2018

chromeos: Cleanup usage of IsAshInBrowserProcess, part 3

We need to distinguish between MultiProcessMash, SingleProcessMash and
both (aka IsUsingWindowService).

* Power - ML and settings UI
* Exo
* WebRTC desktop capture
* Tabs extension API
* Tab dragging
* TestBrowserDialog

The remaining ones are in browser frame code.

Bug:  874468 
Change-Id: Iac58a63b518966e781a25a090b58a24b8d2ace95
Reviewed-on: https://chromium-review.googlesource.com/1183790
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584912}
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/ash/app_list/app_list_controller_impl.cc
[add] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/chromeos/power/ml/DEPS
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/chromeos/power/ml/user_activity_controller.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/exo_parts.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/ui/app_list/search/answer_card/answer_card_web_contents.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/ui/test/test_browser_dialog.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/ui/views/chrome_views_delegate_chromeos.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/ui/views/tabs/window_finder_chromeos.cc
[modify] https://crrev.com/913f1641f753a2a10c0dfc3bbfc0ae345474ef3a/chrome/browser/ui/webui/settings/md_settings_ui.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ba397e329443b4716e28afd1aa3379401218217

commit 5ba397e329443b4716e28afd1aa3379401218217
Author: James Cook <jamescook@chromium.org>
Date: Wed Aug 22 03:29:31 2018

chromeos: Cleanup usage of IsAshInBrowserProcess, part 4

We need to distinguish between MultiProcessMash, SingleProcessMash and
both (aka IsUsingWindowService).

This is the last of the uses in //chrome/browser. It mostly covers
window frames.

Bug:  874468 
Change-Id: Ia6ab9e9a5fc0787f3f295f8ce8a3efff46b37e6b
Reviewed-on: https://chromium-review.googlesource.com/1184115
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584953}
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/ash/tab_scrubber.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/views/frame/browser_frame_ash.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/views/frame/browser_frame_ash_browsertest.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
[modify] https://crrev.com/5ba397e329443b4716e28afd1aa3379401218217/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e6a7aed3eb90f490fe561cd62cdd43702775d91

commit 7e6a7aed3eb90f490fe561cd62cdd43702775d91
Author: James Cook <jamescook@chromium.org>
Date: Fri Aug 24 23:00:47 2018

chromeos: Eliminate features::IsAshInBrowserProcess

Switch everything to:
* IsUsingWindowService
* IsSingleProcessMash
* IsMultiProcessMash

Hopefully this makes it clearer when ash really is in the browser
process.

Fix one keyboard-related conditional too.

TBR=kbr@chromium.org

Bug:  874468 
Test: ash_unittests with SingleProcessMash locally, spot check browser_tests
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0d175240dfff820cbf612fb7e30fec72ba5b81a2
Reviewed-on: https://chromium-review.googlesource.com/1188750
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586035}
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/accessibility/accessibility_highlight_controller.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/display/display_color_manager.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/frame/header_view.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/frame/non_client_frame_view_ash_unittest.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/shell.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/system/flag_warning/flag_warning_tray.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/system/network/network_list.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/system/status_area_widget.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ash/ws/window_service_owner.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/components/arc/ime/arc_ime_service.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/components/services/pdf_compositor/pdf_compositor_service.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/content/browser/browser_main_loop.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/content/renderer/media/media_factory.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ui/base/ui_base_features.cc
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ui/base/ui_base_features.h
[modify] https://crrev.com/7e6a7aed3eb90f490fe561cd62cdd43702775d91/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc

Comment 9 by jamescook@chromium.org, Aug 24

Status: Fixed (was: Started)
►

Sign in to add a comment