New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874464 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Aug 16
Cc:
█ vollick@chromium.org
agrieve@chromium.org
tiborg@chromium.org
estevenson@chromium.org
cjgrant@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

monochrome public release build is crashing at ToT

Project Member Reported by cjgrant@chromium.org, Aug 15 
Within the past few days, it appears monochrome release builds started crashing at ToT.

I'm running a bisect to try and identify when the issue started.


08-15 10:57:49.806  7277  7348 D libEGL  : loaded /vendor/lib/egl/libEGL_adreno.so
08-15 10:57:49.812  7277  7348 D libEGL  : loaded /vendor/lib/egl/libGLESv1_CM_adreno.so
08-15 10:57:49.826  7277  7348 D libEGL  : loaded /vendor/lib/egl/libGLESv2_adreno.so
08-15 10:57:49.856  1105  2752 W ActivityManager: Background start not allowed: service Intent { cmp=com.google.vr.vrcore/.common.VrCoreSdkService } to com.google.vr.vrcore/.common.VrCoreSdkService from pid=7323 uid=10108 pkg=com.google.vr.vrcore
08-15 10:57:49.871  7277  7357 I cr_LibraryLoader: Time to load native libraries: 24 ms (timestamps 2508-2532)
08-15 10:57:49.872  7277  7357 I chromium: [INFO:library_loader_hooks.cc(36)] Chromium logging enabled: level = 0, default verbosity = 0
08-15 10:57:49.872  7277  7357 I cr_LibraryLoader: Expected native library version number "70.0.3524.0", actual native library version number "70.0.3524.0"
08-15 10:57:49.873  7277  7366 W chromium: [WARNING:library_prefetcher.cc(300)] Incorrect code ordering
08-15 10:57:49.873  7277  7366 W chromium: [WARNING:library_prefetcher.cc(204)] Incorrect code ordering
08-15 10:57:49.873  7277  7366 W chromium: [WARNING:library_prefetcher.cc(274)] Cannot prefetch the library. status = 1
08-15 10:57:49.875  7277  7277 D AndroidRuntime: Shutting down com.google.ipc.invalidation.ticl.proto.JavaClient$InvalidationClientState$Builder
08-15 10:57:49.875  7277  7277 E AndroidRuntime: FATAL EXCEPTION: main
08-15 10:57:49.875  7277  7277 E AndroidRuntime: Process: org.chromium.chrome, PID: 7277
08-15 10:57:49.875  7277  7277 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{org.chromium.chrome/org.chromium.chrome.browser.ChromeTabbedActivity}: android.view.InflateException: Binary XML file line #22: Binary XML file line #22: Er
ror inflating class ImageView
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2778)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.app.ActivityThread.-wrap11(ActivityThread.java:0)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:106)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.os.Looper.loop(Looper.java:164)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:6494)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at java.lang.reflect.Method.invoke(Method.java)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: Caused by: android.view.InflateException: Binary XML file line #22: Binary XML file line #22: Error inflating class ImageView
08-15 10:57:49.875  7277  7277 E AndroidRuntime: Caused by: android.view.InflateException: Binary XML file line #22: Error inflating class ImageView
08-15 10:57:49.875  7277  7277 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void rS.d()' on a null object reference
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.support.v7.widget.AppCompatImageView.setImageDrawable(AppCompatImageView.java:101)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.widget.ImageView.<init>(ImageView.java:190)
08-15 10:57:49.875  7277  7277 E AndroidRuntime: at android.widget.ImageView.<init>(ImageView.java:171)

Comment 1 by cjgrant@chromium.org, Aug 15 

The problem has been narrowed to this change:

commit 4cdc1153e6f6a1182aec5fe42c072db5241b4c3f
Author: Eric Stevenson <estevenson@chromium.org>
Date:   Wed Aug 1 08:20:38 2018 +0000

    Android: Update proguard to 6.0.3.
    
    This is a reland of df22b81425e5487282a2569f9fd274300a43e3e5.
    
    The CL now forwards proguard_jar_path properly.
    
    Original change's description:
    > Use proguard version 6.0.3 for monochrome_public_apk.
    >
    > MonochromePublic.apk release builds are very close to the main dex limit
    > and updating proguard reduces the number of methods by about 3000.
    >
    > 6.0.3 cannot be used for all APKs yet due to a bug which causes
    > cronet_test_instrumentation_apk to fail.
    >
    > The version mismatch should be temporary as we plan to switch to R8 in the
    > future ( https://crbug.com/868770 ).
    >
    > Bug:  857572 
    > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
    > Change-Id: I3676a42908c5046dc3f3831e282150702038140d
    > Reviewed-on: https://chromium-review.googlesource.com/1154366
    > Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    > Commit-Queue: Eric Stevenson <estevenson@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#579250}
    
    Bug:  857572 
    Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ia52b36e04623c5b72e668bb6c07be018ac9210b5
    Reviewed-on: https://chromium-review.googlesource.com/1156004

Comment 3 by cjgrant@chromium.org, Aug 15

Cc: agrieve@chromium.org

Comment 4 by cjgrant@chromium.org, Aug 15

Labels: Target-70

Comment 5 by tiborg@chromium.org, Aug 15

Cc: cjgrant@chromium.org
Owner: tiborg@chromium.org
Working on a fix. To summarize the problem, the proguard update caused removal of R.style IDs that we then tried to inflate. The intended solution is to revert the proguard update and use multidex in release for monochrome to stay below the DEX method limit.

Comment 6 by tiborg@chromium.org, Aug 15

Cc: estevenson@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c99f1915968868430b596db831d90d9b208e93ab

commit c99f1915968868430b596db831d90d9b208e93ab
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Aug 16 14:14:39 2018

[build:android] Use default proguard and multidex for monochrome release

Monochrome is crashing on startup. Fix this by using the default
proguard instead of proguard 6.0.3 for monochrome. In order to stay
under the DEX method limit use multidex for monochrome release builds.

Bug:  874464 ,  868770 
Change-Id: I9f002c26fb6e2b9b1b5d7471dab890090c446a75
Reviewed-on: https://chromium-review.googlesource.com/1176474
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583639}
[modify] https://crrev.com/c99f1915968868430b596db831d90d9b208e93ab/build/config/android/rules.gni
[modify] https://crrev.com/c99f1915968868430b596db831d90d9b208e93ab/chrome/android/BUILD.gn
[modify] https://crrev.com/c99f1915968868430b596db831d90d9b208e93ab/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/c99f1915968868430b596db831d90d9b208e93ab/third_party/proguard/README.chromium
[delete] https://crrev.com/81bcbe408b0b06d4f534f572a0eaeb4b22f245ca/third_party/proguard/lib/proguard.6.0.3.jar

Comment 8 by tiborg@chromium.org, Aug 16 

Hopefully, this is fixed now.

Comment 9 by tiborg@chromium.org, Aug 16

Status: Fixed (was: Started)
►

Sign in to add a comment