New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874456 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 783184
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Files search is very slow from the Launcher

Project Member Reported by weifangsun@chromium.org, Aug 15

Issue description

Please see feedback report for logs -

https://listnr.corp.google.com/report/85601869709

Observed that it took over a min to return a search result from Drive. Note: The user has 34 Team Drives.

When testing on my account on the same version, search is performing ok - Not super fast, but not as slow as observed above.
 
Labels: CrOSFilesCategory-Performance CrOSFilesFeature-TeamDrives
Owner: slangley@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46c58ef1cc4b22a393c7841bad51015e8fe2051c

commit 46c58ef1cc4b22a393c7841bad51015e8fe2051c
Author: Stuart Langley <slangley@google.com>
Date: Fri Aug 24 05:58:51 2018

Introduce a throttled queue for background team drive operations.

During normal processing, the file system starts a number of periodic requests
to drive to refresh state. Many of these are not in response to user input and
can complete gradually. However the underlying drive service has no way to
differentiate between user initiate requests and background requests and uses
the same processing queue for both, resulting in user initiated requests being
delayed.

This CL introduces a rate limited queue that the file system can use for
requesting background requests, so that we always have capacity to quickly
service user initiated requests.

Bug:  874456 
Change-Id: I5c041d7406f99d7f70af89aacc84bec39134f9a4
Reviewed-on: https://chromium-review.googlesource.com/1179119
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585712}
[modify] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/components/drive/BUILD.gn
[add] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/components/drive/chromeos/drive_operation_queue.h
[modify] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/components/drive/chromeos/file_system.h
[modify] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/components/drive/chromeos/team_drive_change_list_loader.cc
[modify] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/components/drive/chromeos/team_drive_change_list_loader.h
[add] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/components/drive/drive_operation_queue_unittest.cc
[modify] https://crrev.com/46c58ef1cc4b22a393c7841bad51015e8fe2051c/components/drive/file_system_unittest.cc

Cc: weifangsun@chromium.org mcirimele@chromium.org nya@chromium.org
 Issue 760476  has been merged into this issue.
Mergedinto: 783184
Status: Duplicate (was: Started)
Duping this bug against the main drive performance related bug.

Sign in to add a comment