New issue
Advanced search Search tips

Issue 874450 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove the Budget API

Project Member Reported by peter@chromium.org, Aug 15

Issue description

The Budget API hasn't gotten any traction and there doesn't seem to be sufficient demand either, so let's remove it while we can. More details in the Intent to Remove sent to blink-dev@:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/18r3whCBv0I


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8

commit afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8
Author: Peter Beverloo <peter@chromium.org>
Date: Mon Aug 20 13:03:45 2018

Remove the Budget API

The API hasn't been adopted by developers leading to practically zero
usage. Given that there isn't a clear path to interoperability either,
let's remove it. This has been approved per the following Intent to
Remove on blink-dev:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/18r3whCBv0I

The specification draft has been updated to mention its obsolescence:

https://wicg.github.io/budget-api/

There are a few bits of browser-side budget-related code that are being
used by push messaging. This CL also moves the relevant class
(BudgetDatabase) to the push messaging directory, and updated it to
maintain logic, while removing the dependency on the Mojo types.

Bug:  873540 ,  874450 
Change-Id: I98dcefe5b4333b969dd3c9bd4c09e9aaf9d65579
Reviewed-on: https://chromium-review.googlesource.com/1176083
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584418}
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/OWNERS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager_browsertest.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager_factory.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager_factory.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_manager_unittest.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_service_impl.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/budget_service/budget_service_impl.h
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/chrome_content_browser_manifest_overlay.json
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/BUILD.gn
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/budget.proto
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/budget_database.cc
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/budget_database.h
[rename] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/budget_database_unittest.cc
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/push_messaging_notification_manager.cc
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/push_messaging_notification_manager.h
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/browser/push_messaging/push_messaging_service_factory.cc
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/chrome/test/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/test/data/budget_service/budget_test.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/test/data/budget_service/service_worker.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/test/data/budget_service/test.html
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/external/wpt/budget-api/interfaces.any-expected.txt
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/external/wpt/budget-api/interfaces.any.worker-expected.txt
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/OWNERS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-budget.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-fails-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/interfaces-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/reserve.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces.html
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/budget-api-origin-trial-interfaces-worker-disabled.js
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/budget-api-origin-trial-interfaces-worker-enabled.php
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/budget-service-on-insecure-origin.html
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/public/platform/modules/budget_service/OWNERS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/public/platform/modules/budget_service/budget_service.mojom
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/blink/renderer/modules/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/BUILD.gn
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/DEPS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/OWNERS
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_service.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_service.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_service.idl
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_state.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_state.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/budget_state.idl
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/navigator_budget.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/navigator_budget.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/navigator_budget.idl
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/worker_navigator_budget.cc
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/worker_navigator_budget.h
[delete] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/third_party/blink/renderer/modules/budget/worker_navigator_budget.idl
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment