Chrome cleanup scanner is leaking handles while scanning |
|||||
Issue description
The cleanup tool is using a lot of handles while scanning.
We are observing >250k handles opened by scanning process.
To repro:
1) navigate to chrome://settings/cleanup
2) open procexp or process hacker, and look to the amount
of handles for software_reporter_tools.exe
See attachments.
,
Aug 15
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f43ac6b091b8c2f0235a2613638c60cc05638bc commit 1f43ac6b091b8c2f0235a2613638c60cc05638bc Author: Etienne Bergeron <etienneb@chromium.org> Date: Wed Aug 15 20:12:57 2018 Add trace probe for chrome cleaner tasks This CL is adding trace events under the tracing category "safe_browsing" to determine whether or not chrome cleanup tool is running. This is useful to determine if the cleanup tool scanning/cleaning is affecting chrome by looking to the slow-reports. We currently can't determine whether or not the tool is running. R=csharp@chromium.org CC=etienneb@chromium.org Bug: 874448 Change-Id: I4b54ea470caab6ce63542bedd1169ab667aac008 Reviewed-on: https://chromium-review.googlesource.com/1176137 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583370} [modify] https://crrev.com/1f43ac6b091b8c2f0235a2613638c60cc05638bc/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc [modify] https://crrev.com/1f43ac6b091b8c2f0235a2613638c60cc05638bc/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc
,
Aug 16
The broker process is indeed leaking handles.
,
Aug 16
You might want to keep an eye on Will's comments on https://chromium-review.googlesource.com/c/chromium/src/+/1172733 - he had some questions about DuplicateHandle there, it's possible he'll spot something.
,
Aug 16
You may want to get the number of handles still open at the end of your process execution and log that metric. see: https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-getprocesshandlecount
,
Aug 16
The cause was found, the fix is on the way.
,
Aug 16
The following revision refers to this bug: https://chrome-internal.googlesource.com/protector/foil/+/226ad7e72bcf58fde11d0355d3b6b4ca649db6b2 commit 226ad7e72bcf58fde11d0355d3b6b4ca649db6b2 Author: Veranika Liaukevich <veranika@google.com> Date: Thu Aug 16 21:15:02 2018
,
Aug 17
,
Sep 13
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by etienneb@chromium.org
, Aug 15