New issue
Advanced search Search tips

Issue 874445 link

Starred by 1 user
Status: Fixed
Owner:
chaopeng@chromium.org
Closed: Aug 30
Cc:
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 836890
issue 870422



Sign in to add a comment

[BlinkGenPropertyTrees] draw_property_utils.cc: Check failed: elastic_overscroll.IsZero().

Project Member Reported by pdr@chromium.org, Aug 15 
If I launch chrome with --enable-blink-gen-property-trees and scroll to the top or bottom of the page on MacOS, I hit the following exception:
draw_property_utils.cc(473) Check failed: elastic_overscroll.IsZero(). 
0  base::debug::StackTrace::StackTrace(unsigned long) + 174
1  base::debug::StackTrace::StackTrace(unsigned long) + 29
2  base::debug::StackTrace::StackTrace() + 28
3  logging::LogMessage::~LogMessage() + 460
4  logging::LogMessage::~LogMessage() + 21
5  void cc::draw_property_utils::(anonymous namespace)::UpdateElasticOverscrollInternal<cc::LayerImpl>(cc::PropertyTrees*, cc::LayerImpl const*, gfx::Vector2dF const&) + 205
6  cc::draw_property_utils::UpdateElasticOverscroll(cc::PropertyTrees*, cc::LayerImpl const*, gfx::Vector2dF const&) + 37
7  cc::CalculateDrawPropertiesInternal(cc::LayerTreeHostCommon::CalcDrawPropsImplInputs*, cc::PropertyTreeOption) + 2971
8  cc::LayerTreeHostCommon::CalculateDrawProperties(cc::LayerTreeHostCommon::CalcDrawPropsImplInputs*) + 49
9  cc::LayerTreeImpl::UpdateDrawProperties(bool) + 1809
10 cc::LayerTreeHostImpl::PrepareToDraw(cc::LayerTreeHostImpl::FrameData*) + 3111
11 cc::ProxyImpl::DrawInternal(bool) + 867
12 cc::ProxyImpl::ScheduledActionDrawIfPossible() + 666
13 cc::Scheduler::DrawIfPossible() + 407
14 cc::Scheduler::ProcessScheduledActions() + 1529
15 cc::Scheduler::OnBeginImplFrameDeadline() + 360

Comment 1 by bokan@chromium.org, Aug 15

Cc: -bokan@chromium.org
Owner: bokan@chromium.org
Status: Assigned (was: Available)

Comment 2 by bokan@chromium.org, Aug 16

Cc: bokan@chromium.org
Owner: chaopeng@chromium.org

Comment 3 by chaopeng@chromium.org, Aug 17 

This crash is because the OverscrollElasticityLayer is null. I can see we passed the layer id (viewport_layer_ids_.overscroll_elasticity) to cc.

Comment 5 by bokan@chromium.org, Aug 17 

Yup - that's how we fixed pinch-zoom and other viewport related transforms. This is closely related so sgtm

Comment 6 by bokan@chromium.org, Aug 24

Blocking: -836912 836890
Blocking on scrolling bug as this is unrelated to scrollbars

Comment 7 by pdr@chromium.org, Aug 24

Blocking: 870422
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7

commit b90e8a21f4fa4347a694a7699e382ea1ed8a76d7
Author: chaopeng <chaopeng@chromium.org>
Date: Tue Aug 28 20:06:32 2018

[BlinkGenPropertyTrees] Add OverscrollElasticityTransformNode to BGPT

This crash is because the OverscrollElasticityLayer is null in cc.

In this patch, we add OverscrollElasticityTransformNode to BGPT. We also
change cc side logic to use OverscrollElasticityTransformNode and its
element id.

Bug:  874445 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5e4c8ba877ee2b779cfdfc6d7f0a6d8369bd96b4
Reviewed-on: https://chromium-review.googlesource.com/1180561
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586824}
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/test/fake_layer_tree_host.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/test/layer_tree_test.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/draw_property_utils.h
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_host.h
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_host_common.h
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_host_common_perftest.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/cc/trees/property_tree_builder.h
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/components/viz/service/display/bsp_tree_perftest.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[add] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/fixed-body-background-positioned-expected.txt
[add] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/layer-tree-expected.txt
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/public/platform/web_layer_tree_view.h
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/renderer/core/frame/visual_viewport.h
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/renderer/core/paint/paint_property_tree_printer.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/renderer/platform/graphics/compositor_element_id.cc
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/renderer/platform/graphics/compositor_element_id.h
[modify] https://crrev.com/b90e8a21f4fa4347a694a7699e382ea1ed8a76d7/third_party/blink/renderer/platform/testing/viewport_layers_setup.cc

Comment 9 by chaopeng@chromium.org, Aug 30

Status: Fixed (was: Assigned)
►

Sign in to add a comment