New issue
Advanced search Search tips

Issue 874444 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

external/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual.html flaky

Project Member Reported by xidac...@chromium.org, Aug 15

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ade2b1fa35e9b91097be544b43dff8ffb92997ef

commit ade2b1fa35e9b91097be544b43dff8ffb92997ef
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Aug 15 13:58:09 2018

Mark external/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual.html flaky

TBR=wjmaclean@chromium.org
NOTRY=true

Bug:  874444 
Change-Id: Idce66af34aa8a41d8cd300df559a48fca8409040
Reviewed-on: https://chromium-review.googlesource.com/1175699
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583238}
[modify] https://crrev.com/ade2b1fa35e9b91097be544b43dff8ffb92997ef/third_party/WebKit/LayoutTests/TestExpectations

Cc: -foolip@chromium.org
Components: -Blink>Media>Controls Blink>Fullscreen
Owner: foolip@chromium.org
+foolip@, did you write this test by any chance?
Status: Assigned (was: Untriaged)
Owner: dtapu...@chromium.org
Judging by the name it might have been my test. dtapuska@ has made it non-flaky in https://chromium-review.googlesource.com/c/chromium/src/+/1194726
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff

commit c69a8ed7185e0ea8901e2faf19c4ab8257b20aff
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Aug 29 17:19:52 2018

Fix fullscreen WPT tests assuming fullscreenElement changes each time.

Since fullscreenchange event is sent by the rAF event loop it is possible
that the fullscreenElement might change and not be observed at the time
you read the event. Fix the tests so they are robust.

Fix the ordering of which fullscreen elements are handled in pending
frames. Otherwise we might end up with incorrect ordering.

BUG= 874444 

Change-Id: I00c228e0aea7794564e522a3883573ea359235f1
Reviewed-on: https://chromium-review.googlesource.com/1194726
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587170}
[modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9aa404d6e3b8ac31238a4af25ae387407f1094bd/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual-expected.txt
[modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual.html
[modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-two-iframes-manual.html
[modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/blink/renderer/core/frame/fullscreen_controller.cc
[modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/blink/renderer/core/frame/fullscreen_controller.h

Status: Fixed (was: Assigned)

Sign in to add a comment