external/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual.html flaky |
|||||
Issue description
,
Aug 21
+foolip@, did you write this test by any chance?
,
Aug 26
,
Aug 29
Judging by the name it might have been my test. dtapuska@ has made it non-flaky in https://chromium-review.googlesource.com/c/chromium/src/+/1194726
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff commit c69a8ed7185e0ea8901e2faf19c4ab8257b20aff Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Aug 29 17:19:52 2018 Fix fullscreen WPT tests assuming fullscreenElement changes each time. Since fullscreenchange event is sent by the rAF event loop it is possible that the fullscreenElement might change and not be observed at the time you read the event. Fix the tests so they are robust. Fix the ordering of which fullscreen elements are handled in pending frames. Otherwise we might end up with incorrect ordering. BUG= 874444 Change-Id: I00c228e0aea7794564e522a3883573ea359235f1 Reviewed-on: https://chromium-review.googlesource.com/1194726 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#587170} [modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/9aa404d6e3b8ac31238a4af25ae387407f1094bd/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual-expected.txt [modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual.html [modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-two-iframes-manual.html [modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/blink/renderer/core/frame/fullscreen_controller.cc [modify] https://crrev.com/c69a8ed7185e0ea8901e2faf19c4ab8257b20aff/third_party/blink/renderer/core/frame/fullscreen_controller.h
,
Aug 29
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Aug 15