New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874443 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Fix flaky test AdTaggingBrowserTest.VerifyCrossOriginWithoutNavigate

Project Member Reported by csharrison@chromium.org, Aug 15

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e2fc13cb10e8242c00bed07c125a61a5d9f3bda

commit 5e2fc13cb10e8242c00bed07c125a61a5d9f3bda
Author: Eric Robinson <ericrobinson@chromium.org>
Date: Wed Sep 05 14:09:55 2018

Re-enabling Cross Origin Verification.

I've run this test using the Linux Release (with dcheck) 1000 times locally,
and run 3 dry runs here.  I haven't been able to reproduce the flakiness
observed initially.  I'm unsure if there was an underlying issue that was fixed
or if I need to run on some additional architecture.  I plan to re-enable this
and monitor the run tracker so I have a better idea how to address the
flakiness if it still exists.

Bug:  874443 
Change-Id: Ic3a839fd28a105b1b761ddffca5363803b357cc9
Reviewed-on: https://chromium-review.googlesource.com/1203933
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588858}
[modify] https://crrev.com/5e2fc13cb10e8242c00bed07c125a61a5d9f3bda/chrome/browser/subresource_filter/ad_tagging_browsertest.cc

Updating with screenshot of flakiness, which doesn't present itself in standard Linux tests.  Will disable and reproduce using either windows or msan.
flaky.png
85.8 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0471a31cb2b9f3770b8175949a88c6a0eac9884a

commit 0471a31cb2b9f3770b8175949a88c6a0eac9884a
Author: Eric Robinson <ericrobinson@chromium.org>
Date: Thu Sep 06 13:22:27 2018

Revert "Re-enabling Cross Origin Verification."

This reverts commit 5e2fc13cb10e8242c00bed07c125a61a5d9f3bda.

Reason for revert: Discovered that this is flaky under Windows and Linux.memory.  Will reproduce there.

Original change's description:
> Re-enabling Cross Origin Verification.
> 
> I've run this test using the Linux Release (with dcheck) 1000 times locally,
> and run 3 dry runs here.  I haven't been able to reproduce the flakiness
> observed initially.  I'm unsure if there was an underlying issue that was fixed
> or if I need to run on some additional architecture.  I plan to re-enable this
> and monitor the run tracker so I have a better idea how to address the
> flakiness if it still exists.
> 
> Bug:  874443 
> Change-Id: Ic3a839fd28a105b1b761ddffca5363803b357cc9
> Reviewed-on: https://chromium-review.googlesource.com/1203933
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588858}

TBR=csharrison@chromium.org,ericrobinson@chromium.org

Change-Id: I68c86ba816e4e555eee18fc3e744542d80cf7ec2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  874443 
Reviewed-on: https://chromium-review.googlesource.com/1209983
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589147}
[modify] https://crrev.com/0471a31cb2b9f3770b8175949a88c6a0eac9884a/chrome/browser/subresource_filter/ad_tagging_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a35d7e9023240e89556ec56288c54ef9b1eeb377

commit a35d7e9023240e89556ec56288c54ef9b1eeb377
Author: Eric Robinson <ericrobinson@chromium.org>
Date: Fri Sep 07 16:49:04 2018

Adding a dom message to avoid flakiness in Create*Frame scripts.

The test that checked the cross-origin status of a doc-written ad
frame was flaky, and wasn't seeing any histogram entry at all.  The
operating theory is that this was due to the frame itself not
being guaranteed to load all its subresources.  This CL blocks the
test until the subframe's load event is fired to ensure that
subresources have been fully loaded.

Bug:  874443 
Change-Id: If4aa585d1e51dcf1e2350b768d6f6e5dfd3554cd
Reviewed-on: https://chromium-review.googlesource.com/1211085
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589551}
[modify] https://crrev.com/a35d7e9023240e89556ec56288c54ef9b1eeb377/chrome/browser/subresource_filter/ad_tagging_browsertest.cc
[modify] https://crrev.com/a35d7e9023240e89556ec56288c54ef9b1eeb377/chrome/test/data/ad_tagging/ad_script.js
[modify] https://crrev.com/a35d7e9023240e89556ec56288c54ef9b1eeb377/chrome/test/data/ad_tagging/create_frame.js

Comment 5 Deleted

Status: Verified (was: Assigned)
Closing this bug, as the flakiness dashboard is showing that the previous change fixed the issue.

Sign in to add a comment