New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874437 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 4
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.8%-288.2% regression in rendering.mobile at 582986:583026

Project Member Reported by cbruni@google.com, Aug 15

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=874437

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d4fba4640cddded79db83646b281d0604aa266a60ac8ac2eb3e1b14f346282c1


Bot(s) for this bug's original alert(s):

Android Nexus6 WebView Perf
Cc: hpayer@chromium.org
Owner: hpayer@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1693257c640000

[heap] Use std::atomic for page flags. by hpayer@chromium.org
https://chromium.googlesource.com/v8/v8/+/7f3f7e8a9547ece1a7f80ce902bc23632e902b0b
1.977 → 6.64 (+4.663)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
 Issue 874434  has been merged into this issue.
Cc: tdres...@chromium.org jgruber@chromium.org
 Issue 874887  has been merged into this issue.
 Issue 874897  has been merged into this issue.
 Issue 874955  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f29fbf35a91b8808aea1c21071e189b47d6c831b

commit f29fbf35a91b8808aea1c21071e189b47d6c831b
Author: Hannes Payer <hpayer@chromium.org>
Date: Tue Aug 21 20:20:51 2018

[heap] Provide memory order relaxed accessor of page flags.

Bug:  chromium:874437 ,chromium:852420
Change-Id: I4f484a6bb7072804dbcaacab77d25ba7a3fe338f
Reviewed-on: https://chromium-review.googlesource.com/1183188
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55287}
[modify] https://crrev.com/f29fbf35a91b8808aea1c21071e189b47d6c831b/src/heap/spaces.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fc8a34a3f10afd6d4830a3f0093d2b26358cf231

commit fc8a34a3f10afd6d4830a3f0093d2b26358cf231
Author: Hannes Payer <hpayer@chromium.org>
Date: Wed Aug 22 14:40:56 2018

Revert "[heap] Provide memory order relaxed accessor of page flags."

This reverts commit f29fbf35a91b8808aea1c21071e189b47d6c831b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [heap] Provide memory order relaxed accessor of page flags.
> 
> Bug:  chromium:874437 ,chromium:852420
> Change-Id: I4f484a6bb7072804dbcaacab77d25ba7a3fe338f
> Reviewed-on: https://chromium-review.googlesource.com/1183188
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55287}

TBR=ulan@chromium.org,hpayer@chromium.org

Change-Id: I5703641fd99a9dc79e2819af1597d4440e2e9990
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:874437 , chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1185161
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55307}
[modify] https://crrev.com/fc8a34a3f10afd6d4830a3f0093d2b26358cf231/src/heap/spaces.h

Status: Fixed (was: Assigned)

Sign in to add a comment