New issue
Advanced search Search tips

Issue 874408 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 854636



Sign in to add a comment

Move WMI utilities from chrome/installer to components

Project Member Reported by guidou@chromium.org, Aug 15

Issue description

This will make them easier to use in other projects.
Hardware Platform extension API will need this.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73a943026f06d39defe3a9be8cc96dbc9787250a

commit 73a943026f06d39defe3a9be8cc96dbc9787250a
Author: Guido Urdaneta <guidou@chromium.org>
Date: Fri Aug 24 15:42:27 2018

Move WMI utilities from chrome/installer/util to base/win

This makes these utilities easier to use from other projects, which we
plan to do in the upcoming Hardware Platform Extension API
(see crbug.com/854636).

This CL also refactors the function to get the computer manufacturer
and model so that they are available as separate strings, and adds
a number of style/lint fixes.

Bug:  874408 
Change-Id: I408151cc478ccf37a0515d17d1381115b12d9122
Reviewed-on: https://chromium-review.googlesource.com/1175781
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585853}
[modify] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/base/BUILD.gn
[add] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/base/win/wmi.cc
[add] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/base/win/wmi.h
[add] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/base/win/wmi_unittest.cc
[modify] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/chrome/browser/BUILD.gn
[modify] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/chrome/browser/process_singleton_win.cc
[modify] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/chrome/installer/gcapi/DEPS
[modify] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/chrome/installer/gcapi/gcapi.cc
[modify] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/chrome/installer/util/BUILD.gn
[modify] https://crrev.com/73a943026f06d39defe3a9be8cc96dbc9787250a/chrome/installer/util/google_chrome_distribution.cc
[delete] https://crrev.com/ff29b2308bb305800f5023d0f5e09860483ccb4c/chrome/installer/util/wmi.cc
[delete] https://crrev.com/ff29b2308bb305800f5023d0f5e09860483ccb4c/chrome/installer/util/wmi.h
[delete] https://crrev.com/ff29b2308bb305800f5023d0f5e09860483ccb4c/chrome/installer/util/wmi_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment