New issue
Advanced search Search tips

Issue 874402 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: *length < bufsize in gles2_cmd_decoder_passthrough.h

Project Member Reported by ClusterFuzz, Aug 15

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5921813813788672

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  *length < bufsize in gles2_cmd_decoder_passthrough.h
  gpu::error::Error gpu::gles2::GLES2DecoderPassthroughImpl::GetNumericHelper<floa
  gpu::gles2::GLES2DecoderPassthroughImpl::DoGetFloatv
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=512880:512907

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5921813813788672

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 15

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 15

Labels: Test-Predator-Auto-Owner
Owner: piman@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/18afd13d94183587e05cb04031f2ee7d56ba98d9 (gpu fuzzers: AddRef on null pointers).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: piman@chromium.org
Owner: geoffl...@chromium.org
Cc: geoffl...@chromium.org backer@chromium.org hubbe@google.com ericrk@chromium.org
 Issue 842491  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/942e37a1ce7232d97b205e783f9a5d4b11d013af

commit 942e37a1ce7232d97b205e783f9a5d4b11d013af
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Nov 21 00:50:05 2018

Fix incorrect buffer size DCHECK when copying scratch parameters.

Replace '<' with '<=', this was not found until recently because it
required that the result was being copied into the exact last element of
a much larger buffer.

BUG= 874402 
TBR=piman@chromium.org

Change-Id: Ib35552f331f0d9f1f1d19aa4914d1d14ec75ee2d
Reviewed-on: https://chromium-review.googlesource.com/c/1344214
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609874}
[modify] https://crrev.com/942e37a1ce7232d97b205e783f9a5d4b11d013af/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h

Project Member

Comment 6 by ClusterFuzz, Nov 21

ClusterFuzz has detected this issue as fixed in range 609872:609876.

Detailed report: https://clusterfuzz.com/testcase?key=5921813813788672

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  *length < bufsize in gles2_cmd_decoder_passthrough.h
  gpu::error::Error gpu::gles2::GLES2DecoderPassthroughImpl::GetNumericHelper<floa
  gpu::gles2::GLES2DecoderPassthroughImpl::DoGetFloatv
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=512880:512907
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=609872:609876

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5921813813788672

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 21

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5921813813788672 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment