Issue 874385 link

Starred by 5 users

Issue metadata

Status:	Available
Owner:	----
Components:	Blink>DOM
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Hotlist-GoodFirstBug

Blocked on:
issue 871637

Use a reference, instead of a pointer, if it never be nullptr

Project Member Reported by hayato@chromium.org, Aug 15

Issue description

There are still a lot of Blink style violations in our codebase, renderer/core/dom.

e.g. Node::InsertedInto(ContainerNode* insertion_point), where insertion_point is never nullptr.

This is a meta bug to track all efforts to follow Blink's style guide for core/dom codebase.

Note that this issue is not specific to core/dom, but let's start with core/dom at first.

Comment 1 by hayato@chromium.org, Aug 15

Blockedon: 871637

Comment 2 by hayato@chromium.org, Aug 15

Labels: Hotlist-GoodFirstBug

Comment 3 Deleted

Comment 4 by codei...@gmail.com, Aug 17

Hi~ Can I try this if anyone didn't start yet?

Comment 5 by hs1217....@samsung.com, Aug 17

sorry. i started this issue. and my cl already got a review points.

Comment 6 by hs1217....@samsung.com, Aug 17

@codeimpl
i did about Node::InsertedInto(ContainerNode* insertion_point).
but i think there are a lot of same issue.
so how about looking for another.

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cfd653c560be7e2ef8333ad580d4c54d7563b2d

commit 9cfd653c560be7e2ef8333ad580d4c54d7563b2d
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Fri Aug 17 02:54:39 2018

Use ContainerNode& instead of ContainerNode* as a parameter of InsertedInto

When InsertedInto is called, ContainerNode object was passed as a parameter.
and it is never nullptr. so it can be changed to reference instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If6eb4e4d0a927d4f6954bd177c16e58798292886
Reviewed-on: https://chromium-review.googlesource.com/1177530
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583948}
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/container_node.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/document_type.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/document_type.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/processing_instruction.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/processing_instruction.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/shadow_root.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/v0_insertion_point.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/dom/v0_insertion_point.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_button_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_button_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_form_control_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_form_control_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_form_control_element_with_state.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_form_control_element_with_state.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_form_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_input_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_opt_group_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_opt_group_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_option_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/html_option_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/listed_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/listed_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/picker_indicator_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/forms/picker_indicator_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_anchor_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_base_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_base_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_body_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_body_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_frame_element_base.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_frame_element_base.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_frame_set_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_frame_set_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_hr_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_hr_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_iframe_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_iframe_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_image_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_image_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_link_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_map_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_map_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_marquee_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_marquee_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_meta_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_meta_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_object_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_object_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_picture_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_picture_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_script_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_script_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_slot_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_source_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_source_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_style_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_style_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_title_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/html_title_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/portal/html_portal_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/track/html_track_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/html/track/html_track_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/animation/svg_smil_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/animation/svg_smil_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_animate_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_animate_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_fe_image_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_fe_image_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_gradient_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_gradient_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_image_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_image_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_mpath_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_mpath_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_path_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_path_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_pattern_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_pattern_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_script_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_script_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_style_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_style_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_svg_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_svg_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_text_path_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_text_path_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_title_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_title_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_use_element.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/core/svg/svg_use_element.h
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/9cfd653c560be7e2ef8333ad580d4c54d7563b2d/third_party/blink/renderer/modules/media_controls/media_controls_impl.h

Comment 8 by hayato@chromium.org, Aug 17

If someone is looking for another, Node::removedFrom(ContainerNode* insertion_point) would be a good candidate.

If you need more, please ask that in this bug. I can provide a lot. :)

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a71a0b423564875e43fd2232341effd992a84c

commit 77a71a0b423564875e43fd2232341effd992a84c
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Fri Aug 17 07:33:43 2018

Use ContainerNode& instead of ContainerNode* as a parameter of RemovedFrom

When RemovedFrom called, ContainerNode object was passed as a parameter.
and it is never nullptr. so it can be changed to reference instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I91a80d4f49c80730791fe2dfa5f9977404b5bd48
Reviewed-on: https://chromium-review.googlesource.com/1179481
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#583984}
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/container_node.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/document_type.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/document_type.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/processing_instruction.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/processing_instruction.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/pseudo_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/shadow_root.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/v0_insertion_point.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/dom/v0_insertion_point.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_form_control_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_form_control_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_form_control_element_with_state.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_form_control_element_with_state.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_form_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_input_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_opt_group_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_opt_group_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_option_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/html_option_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/listed_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/forms/listed_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_base_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_base_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_dialog_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_dialog_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_hr_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_hr_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_iframe_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_iframe_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_image_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_image_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_link_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_map_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_map_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_marquee_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_marquee_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_object_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_object_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_plugin_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_slot_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_source_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_source_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_style_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_style_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_title_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/html_title_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/portal/html_portal_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/track/html_track_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/html/track/html_track_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/animation/svg_smil_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/animation/svg_smil_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_animate_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_animate_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_fe_image_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_fe_image_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_gradient_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_gradient_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_mpath_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_mpath_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_path_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_path_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_pattern_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_pattern_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_style_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_style_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_svg_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_svg_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_text_path_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_text_path_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_title_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_title_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_use_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/core/svg/svg_use_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/modules/media_controls/elements/media_control_loading_panel_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/modules/media_controls/elements/media_control_loading_panel_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.h
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/77a71a0b423564875e43fd2232341effd992a84c/third_party/blink/renderer/modules/media_controls/media_controls_impl.h

Comment 10 by gautham....@gmail.com, Aug 17

@hayato could you please provide another? I would like to work on one.

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eca7f41983186468d08839d2ba2ecb76c248f54

commit 2eca7f41983186468d08839d2ba2ecb76c248f54
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Aug 17 09:36:18 2018

Update FooEvent* arguments of functions called by DefaultEventHandler()s in core/html/forms/.

Update them to |FooEvent&| or |const FooEvent&|.

This CL has no behavior changes.

Bug: 874385
Change-Id: I656a03f466b70defd0769db78c9b3946ef515a08
Reviewed-on: https://chromium-review.googlesource.com/1179545
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584000}
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/base_checkable_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/base_checkable_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/checkbox_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/checkbox_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/chooser_only_temporal_input_type_view.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/chooser_only_temporal_input_type_view.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/color_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/color_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/date_time_field_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/date_time_field_element.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/date_time_numeric_field_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/date_time_numeric_field_element.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/date_time_symbolic_field_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/date_time_symbolic_field_element.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/file_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/file_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/html_button_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/html_form_element.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/html_select_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/html_select_element.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/html_text_area_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/image_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/image_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/input_type_view.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/input_type_view.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/keyboard_clickable_input_type_view.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/keyboard_clickable_input_type_view.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/number_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/number_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/radio_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/radio_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/range_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/range_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/reset_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/reset_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/search_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/search_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/spin_button_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/spin_button_element.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/submit_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/submit_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/text_control_element.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/text_control_element.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/text_field_input_type.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/text_field_input_type.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/type_ahead.cc
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/type_ahead.h
[modify] https://crrev.com/2eca7f41983186468d08839d2ba2ecb76c248f54/third_party/blink/renderer/core/html/forms/type_ahead_test.cc

Comment 12 by codei...@gmail.com, Aug 17

Could you provide me more issue? I will try them with my friends~

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb69514e2d9e91a33ef58ece1ed6c5565469982c

commit cb69514e2d9e91a33ef58ece1ed6c5565469982c
Author: Byoungkown <codeimpl@gmail.com>
Date: Mon Aug 20 02:11:41 2018

Update FooEvent* arguments of functions called by DefaultEventHandler()

Update FooEvent* arguments of functions called by DefaultEventHandler()
in core/html/.
The arguments of functions never be nullptr, so it need to be reference
instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I65925d4cf194482dd7216347fcbbec15e7f31089
Reviewed-on: https://chromium-review.googlesource.com/1180627
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#584352}
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/exported/web_plugin_container_impl.h
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/html/html_anchor_element.h
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/html/html_element.cc
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/html/html_element.h
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/html/html_frame_set_element.cc
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/layout/layout_frame_set.cc
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/layout/layout_frame_set.h
[modify] https://crrev.com/cb69514e2d9e91a33ef58ece1ed6c5565469982c/third_party/blink/renderer/core/svg/svg_a_element.cc

Comment 14 by hayato@chromium.org, Aug 20

Blockedon: -871637

Comment 15 by hayato@chromium.org, Aug 20

Blockedon: 871637

 Issue 871637  has been merged into this issue.

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/971386358e0bc36d157978873a6245269d369cf7

commit 971386358e0bc36d157978873a6245269d369cf7
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Tue Aug 28 06:24:39 2018

Use Event& instead of Event* as a parameter of PostDispatchEventHandler

When PostDispatchEventHandler is called,
Event object was passed as a parameter. and it is never nullptr.
so it can be changed to reference instead of pointer.
and DidDispatchClick is also same.

Bug: 874385

Change-Id: I13042aa1eb949007db554d8bb98d8789102dfaba
Reviewed-on: https://chromium-review.googlesource.com/1189324
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#586599}
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/html/forms/checkbox_input_type.cc
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/html/forms/checkbox_input_type.h
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/html/forms/html_input_element.h
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/html/forms/input_type_view.cc
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/html/forms/input_type_view.h
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/html/forms/radio_input_type.cc
[modify] https://crrev.com/971386358e0bc36d157978873a6245269d369cf7/third_party/blink/renderer/core/html/forms/radio_input_type.h

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38c16e02856dffbfa5232d7dc25f1d223dffd4bd

commit 38c16e02856dffbfa5232d7dc25f1d223dffd4bd
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Mon Sep 10 05:10:35 2018

Use ContainerNode& instead of ContainerNode* as a parameter

When RemovedFrom called, ContainerNode object was passed as a parameter.
and it is never nullptr. so it can be changed to reference instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I231b13529f83540c7ad64d023d7421bc7a3f8ef6
Reviewed-on: https://chromium-review.googlesource.com/1215142
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#589827}
[modify] https://crrev.com/38c16e02856dffbfa5232d7dc25f1d223dffd4bd/third_party/blink/renderer/core/css/style_element.cc
[modify] https://crrev.com/38c16e02856dffbfa5232d7dc25f1d223dffd4bd/third_party/blink/renderer/core/css/style_element.h
[modify] https://crrev.com/38c16e02856dffbfa5232d7dc25f1d223dffd4bd/third_party/blink/renderer/core/html/html_style_element.cc
[modify] https://crrev.com/38c16e02856dffbfa5232d7dc25f1d223dffd4bd/third_party/blink/renderer/core/svg/svg_style_element.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/483db0963e41be3acf6a9a012f51d9b772b8d025

commit 483db0963e41be3acf6a9a012f51d9b772b8d025
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Thu Sep 20 04:07:26 2018

Use Element& instead of Element* as a parameter of HasEquivalentAttributes

When HasEquivalentAttributes is called, Element object was passed as
a parameter.
and it is never nullptr. so it can be changed to reference instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I237a11e88236ef195ade12ee26b0722786f17e29
Reviewed-on: https://chromium-review.googlesource.com/1232810
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592681}
[modify] https://crrev.com/483db0963e41be3acf6a9a012f51d9b772b8d025/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/483db0963e41be3acf6a9a012f51d9b772b8d025/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/483db0963e41be3acf6a9a012f51d9b772b8d025/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/483db0963e41be3acf6a9a012f51d9b772b8d025/third_party/blink/renderer/core/editing/commands/editing_commands_utilities.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e35d508122dbc9480fa46fd64500947a9d9823a

commit 2e35d508122dbc9480fa46fd64500947a9d9823a
Author: Hayato Ito <hayato@chromium.org>
Date: Tue Nov 13 03:48:13 2018

Use a reference instead of a pointer in core/dom/events.

They never be nullptr. There are still other places which should be
a reference, which can be done in another CL.

Bug: 874385
Change-Id: I278e022b40a621115d627ac21cdbb9658f98733e
Reviewed-on: https://chromium-review.googlesource.com/c/1333167
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607478}
[modify] https://crrev.com/2e35d508122dbc9480fa46fd64500947a9d9823a/third_party/blink/renderer/core/animation/css/css_animations.cc
[modify] https://crrev.com/2e35d508122dbc9480fa46fd64500947a9d9823a/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/2e35d508122dbc9480fa46fd64500947a9d9823a/third_party/blink/renderer/core/dom/events/event_path.cc
[modify] https://crrev.com/2e35d508122dbc9480fa46fd64500947a9d9823a/third_party/blink/renderer/core/dom/events/event_path.h
[modify] https://crrev.com/2e35d508122dbc9480fa46fd64500947a9d9823a/third_party/blink/renderer/core/dom/events/node_event_context.cc
[modify] https://crrev.com/2e35d508122dbc9480fa46fd64500947a9d9823a/third_party/blink/renderer/core/dom/events/node_event_context.h
[modify] https://crrev.com/2e35d508122dbc9480fa46fd64500947a9d9823a/third_party/blink/renderer/core/dom/events/tree_scope_event_context.h

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0be223f83675cd8fa2b5a99d097a9fe9f6c38c46

commit 0be223f83675cd8fa2b5a99d097a9fe9f6c38c46
Author: Hayato Ito <hayato@chromium.org>
Date: Tue Nov 13 04:53:49 2018

Use a reference instead of a pointer in core/dom/events.

- EventPath::GetTreeScopeEventContext(TreeScope&)
- Node& NodeEventContext::GetNode()
- TouchEventContext& TreeScopeEventContext::EnsureTouchEventContext()

They never be nullptr.

Bug: 874385

Change-Id: I38167ee25dd01113aae7cbbdb97101fce7a07a2e
Reviewed-on: https://chromium-review.googlesource.com/c/1332969
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607492}
[modify] https://crrev.com/0be223f83675cd8fa2b5a99d097a9fe9f6c38c46/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/0be223f83675cd8fa2b5a99d097a9fe9f6c38c46/third_party/blink/renderer/core/dom/events/event_path.cc
[modify] https://crrev.com/0be223f83675cd8fa2b5a99d097a9fe9f6c38c46/third_party/blink/renderer/core/dom/events/event_path.h
[modify] https://crrev.com/0be223f83675cd8fa2b5a99d097a9fe9f6c38c46/third_party/blink/renderer/core/dom/events/node_event_context.h
[modify] https://crrev.com/0be223f83675cd8fa2b5a99d097a9fe9f6c38c46/third_party/blink/renderer/core/dom/events/tree_scope_event_context.cc
[modify] https://crrev.com/0be223f83675cd8fa2b5a99d097a9fe9f6c38c46/third_party/blink/renderer/core/dom/events/tree_scope_event_context.h
[modify] https://crrev.com/0be223f83675cd8fa2b5a99d097a9fe9f6c38c46/third_party/blink/renderer/core/input/pointer_event_manager.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2660462e8fd09dd4bda5f3e4c1b49c1bec79ef5a

commit 2660462e8fd09dd4bda5f3e4c1b49c1bec79ef5a
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Mon Jan 07 06:23:54 2019

Use Node& instead of Node* as a parameter

When RemoveFocusedElementOfSubtree is called, Node object was passed
as a parameter. and it is never nullptr.
so it can be changed to reference instead of pointer.

Bug: 874385
Change-Id: I20bcb271ced7c1fb82c73dc3dfaa8a4415262501
Reviewed-on: https://chromium-review.googlesource.com/c/1394346
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#620263}
[modify] https://crrev.com/2660462e8fd09dd4bda5f3e4c1b49c1bec79ef5a/third_party/blink/renderer/core/dom/container_node.cc
[modify] https://crrev.com/2660462e8fd09dd4bda5f3e4c1b49c1bec79ef5a/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/2660462e8fd09dd4bda5f3e4c1b49c1bec79ef5a/third_party/blink/renderer/core/dom/document.h

►

Issue 874385 link

Issue metadata

Use a reference, instead of a pointer, if it never be nullptr

Issue description

Comment 1 by hayato@chromium.org, Aug 15

Comment 1 Deleted

Comment 2 by hayato@chromium.org, Aug 15

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by codei...@gmail.com, Aug 17

Comment 4 Deleted

Comment 5 by hs1217....@samsung.com, Aug 17

Comment 5 Deleted

Comment 6 by hs1217....@samsung.com, Aug 17

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Aug 17

Comment 7 Deleted

Comment 8 by hayato@chromium.org, Aug 17

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Aug 17

Comment 9 Deleted

Comment 10 by gautham....@gmail.com, Aug 17

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Aug 17

Comment 11 Deleted

Comment 12 by codei...@gmail.com, Aug 17

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Aug 20

Comment 13 Deleted

Comment 14 by hayato@chromium.org, Aug 20

Comment 14 Deleted

Comment 15 by hayato@chromium.org, Aug 20

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Aug 28

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Sep 10

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Sep 20

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Nov 13

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Nov 13

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Jan 7

Comment 21 Deleted

Sign in to add a comment