New issue
Advanced search Search tips

Issue 874372 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in spvtools::opt::analysis::Struct::GetExtraHashWords

Project Member Reported by ClusterFuzz, Aug 15

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4798524609527808

Fuzzer: libFuzzer_spvtools_opt_legalization_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  spvtools::opt::analysis::Struct::GetExtraHashWords
  spvtools::opt::analysis::Type::GetHashWords
  spvtools::opt::analysis::Type::GetHashWords
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=580304:580310

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4798524609527808

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 15

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 15

Cc: 31666...@users.noreply.github.com d...@everburning.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Update OpPhi instructions after splitting block. (#1783) by 31666470+s-perron@users.noreply.github.com - https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+/ce644d4a2484fe66e53f5b744ebc4d0d5d49e1ca

Remove using std::<foo> statements. (#1756) by dj2@everburning.com - https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+/a5a5ea0e2dfce9c755a88af1074ebe68a44d2ed9

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Cc: -31666...@users.noreply.github.com -d...@everburning.com dsinclair@chromium.org
Owner: stevenperron@google.com
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Invalid code a struct contains itself:

  %_struct_7 = OpTypeStruct %float %_struct_7

The seems to be a bug in the validator that is stopping this from being checked.  https://github.com/KhronosGroup/SPIRV-Tools/pull/1840 was opened to address this issue.
Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Aug 22

Labels: Needs-Feedback
ClusterFuzz testcase 4798524609527808 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
Labels: -Needs-Feedback
This change should be rolling into Chromium now.
Cc: stevenperron@google.com
 Issue 874674  has been merged into this issue.
Project Member

Comment 9 by ClusterFuzz, Aug 28

ClusterFuzz has detected this issue as fixed in range 586270:586271.

Detailed report: https://clusterfuzz.com/testcase?key=4798524609527808

Fuzzer: libFuzzer_spvtools_opt_legalization_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  spvtools::opt::analysis::Struct::GetExtraHashWords
  spvtools::opt::analysis::Type::GetHashWords
  spvtools::opt::analysis::Type::GetHashWords
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=580304:580310
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=586270:586271

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4798524609527808

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Aug 28

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4798524609527808 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
 Issue 878326  has been merged into this issue.

Sign in to add a comment