New issue
Advanced search Search tips

Issue 874371 link

Starred by 1 user
Status: Fixed
Owner:
wychen@chromium.org
Closed: Aug 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Scrolling progress of Simplified view is not retained after zooming

Project Member Reported by wychen@chromium.org, Aug 15 
Chrome Version: M70
OS: Android

What steps will reproduce the problem?
(1) Open an article in Simplified view
(2) Scroll a bit
(3) Pinch to zoom

What is the expected result?
The scrolling position should show roughly the same paragraph.

What happens instead?
The scrolling position is off.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a8b26194dfc7805c64dd37098eb21964403a706

commit 7a8b26194dfc7805c64dd37098eb21964403a706
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Aug 16 00:56:09 2018

Retain scroll position in distiller viewer after zooming

DOM distiller viewer was run in quirks mode, where the body is the
scrolling element. Later on, it was run in standard mode, where
the scrolling element became document.documentElement, and the
scroll positioning logic was broken.

Use document.scrollingElement instead to be more standard compliant.

See https://developer.mozilla.org/en-US/docs/Web/API/Document/scrollingElement

Bug:  874371 
Change-Id: I1a0c04f4bc50ff66a9342e9fde8e0369b79cfef1
Reviewed-on: https://chromium-review.googlesource.com/1175681
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583475}
[modify] https://crrev.com/7a8b26194dfc7805c64dd37098eb21964403a706/components/dom_distiller/core/javascript/dom_distiller_viewer.js

Comment 2 by wychen@chromium.org, Aug 21

Status: Fixed (was: Assigned)
►

Sign in to add a comment