New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874363 link

Starred by 1 user
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: Aug 20
Cc:
kouhei@chromium.org
█ acondor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-45.8% regression in rendering.mobile at 576444:582637

Project Member Reported by kouhei@google.com, Aug 15 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 15 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=874363

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9e524d90227c16c40ec61ae9462da3fb7446a4d57aa64a14d2331c4c2c464bf8


Bot(s) for this bug's original alert(s):

Android Nexus5 Perf
Android Nexus6 WebView Perf
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 15

Cc: acondor@chromium.org
Owner: acondor@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/17d81a88640000

Add default source to the MotionEventSynthetizer by acondor@chromium.org
https://chromium.googlesource.com/chromium/src/+/02cd150c24de8bdebb14d88c1a144b921a47756f
No values → 17.06

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by acondor@chromium.org, Aug 15 

How should I interpreted "No values"? Is this a new metric?
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 15 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1193257c640000

Revert "Add default source to the MotionEventSynthetizer" by acondor@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1175464/1
16.99 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Aug 15 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16963596640000

Remove default source from MotionEventSynthetizerImpl by acondor@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1176379/1
16.95 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14e88d0ddbdd58d346bc9c3bb0629af3fdf56f0f

commit 14e88d0ddbdd58d346bc9c3bb0629af3fdf56f0f
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Mon Aug 20 14:57:16 2018

Remove default source from MotionEventSynthetizerImpl

The used source class was causing several performance regressions.

Bug:  874363 ,  874365 
Change-Id: I697f4380c978aa6c7dbc6d41759bfbbdae0878db
Reviewed-on: https://chromium-review.googlesource.com/1176379
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584442}
[modify] https://crrev.com/14e88d0ddbdd58d346bc9c3bb0629af3fdf56f0f/content/public/android/java/src/org/chromium/content/browser/MotionEventSynthesizerImpl.java

Comment 10 by acondor@chromium.org, Aug 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment