I suspect this is because git_revision is undefined in LUCI case:

https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8938150521431517360/+/steps/sizes/0/logs/chrome.dll-summary.dat/0

This is the commandline we run in the non LUCI builder:
python.exe' -u 'C:\b\rr\tmpjbwmrx\rw\checkout\scripts\tools\runit.py' --show-path --with-third-party-lib -- python 'C:\b\rr\tmpjbwmrx\rw\checkout\scripts\slave\runtest.py' --target Release_x64 --no-xvfb --factory-properties '{"blamelist": ["aleloi@chromium.org"], "bot_id": "build195-m1", "branch": "master", "build_data_dir": "C:\\b\\rr\\tmpneld0c", "build_id": "buildbot/chromium.perf/Win x64 Builder Perf/35536", "builder_id": "master.chromium.perf:Win x64 Builder Perf", "buildername": "Win x64 Builder Perf", "buildnumber": 35536, "git_revision": "5f22a22dc2a40753545192538922a1e1253105fa", "luci_migration": {"status": "ok"}, "mastername": "chromium.perf", "path_config": "kitchen", "project": "src", "recipe": "chromium", "recipe_repository": "https://chromium.googlesource.com/chromium/tools/build.git", "repository": "https://chromium.googlesource.com/chromium/src", "requestedAt": 1534325960, "revision": "5f22a22dc2a40753545192538922a1e1253105fa", "scheduler": "chromium", "slavename": "build195-m1", "workdir": "C:\\b\\build\\slave/Win_x64_Builder_Perf"}' --build-properties '{"blamelist": ["aleloi@chromium.org"], "bot_id": "build195-m1", "branch": "master", "build_data_dir": "C:\\b\\rr\\tmpneld0c", "build_id": "buildbot/chromium.perf/Win x64 Builder Perf/35536", "builder_id": "master.chromium.perf:Win x64 Builder Perf", "buildername": "Win x64 Builder Perf", "buildnumber": 35536, "git_revision": "5f22a22dc2a40753545192538922a1e1253105fa", "luci_migration": {"status": "ok"}, "mastername": "chromium.perf", "path_config": "kitchen", "project": "src", "recipe": "chromium", "recipe_repository": "https://chromium.googlesource.com/chromium/tools/build.git", "repository": "https://chromium.googlesource.com/chromium/src", "requestedAt": 1534325960, "revision": "5f22a22dc2a40753545192538922a1e1253105fa", "scheduler": "chromium", "slavename": "build195-m1", "workdir": "C:\\b\\build\\slave/Win_x64_Builder_Perf"}' '--test-type=sizes' '--builder-name=Win x64 Builder Perf' '--slave-name=build195-m1' '--build-number=35536' --run-python-script '--annotate=graphing' '--results-url=https://chromeperf.appspot.com' '--perf-dashboard-id=sizes' '--perf-id=chromium_perf' 'C:\b\c\b\Win_x64_Builder_Perf\src\infra\scripts\legacy\scripts\slave\chromium\sizes.py' --target Release_x64 --platform win


This is the LUCI one:
python.exe' -u 'c:\b\s\w\ir\kitchen-checkout\scripts\tools\runit.py' --show-path --with-third-party-lib -- python 'c:\b\s\w\ir\kitchen-checkout\scripts\slave\runtest.py' --target Release --no-xvfb --factory-properties '{"bot_id": "build183-m7", "branch": "refs/heads/master", "buildbucket": {"build": {"bucket": "luci.chrome.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1534325775656020, "id": "8938136531423559472", "project": "chrome", "tags": ["builder:win32-builder-perf", "buildset:commit/git/f22c055e4bd497ee3cde9a220e662c4df2cae5ff", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f22c055e4bd497ee3cde9a220e662c4df2cae5ff", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9103566593466987072", "scheduler_job_id:chrome/win32-builder-perf", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}, "buildername": "win32-builder-perf", "buildnumber": 520, "mastername": "chromium.perf", "path_config": "generic", "perf_dashboard_machine_group": "ChromiumPerf", "recipe": "chromium", "repository": "https://chromium.googlesource.com/chromium/src.git", "revision": "f22c055e4bd497ee3cde9a220e662c4df2cae5ff", "slavename": "build183-m7"}' --build-properties '{"bot_id": "build183-m7", "branch": "refs/heads/master", "buildbucket": {"build": {"bucket": "luci.chrome.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1534325775656020, "id": "8938136531423559472", "project": "chrome", "tags": ["builder:win32-builder-perf", "buildset:commit/git/f22c055e4bd497ee3cde9a220e662c4df2cae5ff", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f22c055e4bd497ee3cde9a220e662c4df2cae5ff", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9103566593466987072", "scheduler_job_id:chrome/win32-builder-perf", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}, "buildername": "win32-builder-perf", "buildnumber": 520, "mastername": "chromium.perf", "path_config": "generic", "perf_dashboard_machine_group": "ChromiumPerf", "recipe": "chromium", "repository": "https://chromium.googlesource.com/chromium/src.git", "revision": "f22c055e4bd497ee3cde9a220e662c4df2cae5ff", "slavename": "build183-m7"}' '--test-type=sizes' '--builder-name=win32-builder-perf' '--slave-name=build183-m7' '--build-number=520' --run-python-script '--annotate=graphing' '--results-url=https://chromeperf.appspot.com' '--perf-dashboard-id=sizes' '--perf-id=chromium_perf' 'c:\b\s\w\ir\cache\builder\src\infra\scripts\legacy\scripts\slave\chromium\sizes.py' --target Release --platform win

So it looks like the non LUCI buildbot use "git_revision" to query the git revision in upload script (https://cs.chromium.org/chromium/build/scripts/slave/results_dashboard.py?rcl=745bc1a60125409c42e42e36752d54285a48b816&l=437), whereas LUCI one only has "revision" and not "git_revision".

Since the non LUCI bot has both "git_revision" & "revision" properties and they are the same, I will switch the legacy upload script to use "revision"

Simon: can you verify my theory that "revision" field must be available for the data to be valid?

Also is there anyway to view the perf JSON file to be uploaded to the dashboard? That would give a much better comparison between LUCI vs non LUCI.

I now suspect that the fact that GetActiveMaster() is not replaced with perf_dashboard_machine_group (issue 801289)

I'm not really sure what I'm looking at here. I'm not intimately familiar with the details of the upload script. A glance at it and I don't even see a revision parameter to that upload script, it seems to cobble together a revisions dict from something called slave_utils.GetPerfDashboardRevisionsWithProperties

+eyaich

Emily is probably better suited to comment on how to view the final perf json file to be uploaded.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ccdd71cae2e6bce819a6d8f8b1dcaa27a9e31141

commit ccdd71cae2e6bce819a6d8f8b1dcaa27a9e31141
Author: Nghia Nguyen <nednguyen@google.com>
Date: Wed Aug 15 15:10:43 2018

Make sure we use perf_dashboard_machine_group from build properties when it's available

This is part of the effort to get rid of relying on python class master name ( chromium_utils.GetActiveMaster())
and for migrating to LUCI

BUG:801289,  874358 

Change-Id: I6f02554a3360bef3fc5d89eb089efc07898b21af
Reviewed-on: https://chromium-review.googlesource.com/1175434
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/ccdd71cae2e6bce819a6d8f8b1dcaa27a9e31141/scripts/slave/unittests/runtest_test.py
[modify] https://crrev.com/ccdd71cae2e6bce819a6d8f8b1dcaa27a9e31141/scripts/slave/runtest.py

Yay! That turns out to be the right fix:

https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win64-builder-perf
https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win32-builder-perf

not filed by luci-migration, so removing Via-Luci-Migration.