New issue
Advanced search Search tips

Issue 874354 link

Starred by 1 user
Status: Fixed
Owner:
slangley@chromium.org
Closed: Aug 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

GetRemainingTeamDriveList does not set max results, results in slow loading of files app.

Project Member Reported by slangley@chromium.org, Aug 15 
If users have lots of team drives we fetch them in batches. GetRemainingTeamDriveList() does not set the number of results to fetch, resulting in small batches being retrieved rather than large, slowing the files app load time.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7bdcdc1640dc0b7eda62d3af3ad56c4f6c82466

commit c7bdcdc1640dc0b7eda62d3af3ad56c4f6c82466
Author: Stuart Langley <slangley@google.com>
Date: Wed Aug 15 06:52:36 2018

Make sure we set_max_results when getting remaining team drives.

If the user has a large number of team drives, we fetch the list in batches. If
this value is not set then we get a small amount per batch, resulting in many
more calls to the server to get the list of drives, which degrades app startup
performance.

Bug:  874354 
Change-Id: I82982a6decda3f4a342925b7b3d9872226938cd7
Reviewed-on: https://chromium-review.googlesource.com/1175520
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583184}
[modify] https://crrev.com/c7bdcdc1640dc0b7eda62d3af3ad56c4f6c82466/components/drive/service/drive_api_service.cc

Comment 2 by slangley@chromium.org, Aug 15

Labels: Merge-Request-69
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 16

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cindyb@chromium.org, Aug 17

Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12d5b3127b473cbd1af82cb59ac6a38a389b19f

commit a12d5b3127b473cbd1af82cb59ac6a38a389b19f
Author: Stuart Langley <slangley@google.com>
Date: Fri Aug 17 03:39:14 2018

Make sure we set_max_results when getting remaining team drives.

If the user has a large number of team drives, we fetch the list in batches. If
this value is not set then we get a small amount per batch, resulting in many
more calls to the server to get the list of drives, which degrades app startup
performance.

Bug:  874354 
Change-Id: I82982a6decda3f4a342925b7b3d9872226938cd7
Reviewed-on: https://chromium-review.googlesource.com/1175520
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583184}(cherry picked from commit c7bdcdc1640dc0b7eda62d3af3ad56c4f6c82466)
Reviewed-on: https://chromium-review.googlesource.com/1179402
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#682}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/a12d5b3127b473cbd1af82cb59ac6a38a389b19f/components/drive/service/drive_api_service.cc

Comment 6 by slangley@chromium.org, Aug 17

Status: Fixed (was: Started)
►

Sign in to add a comment