As we have added more and more logging options, it would be great if there is a nice UI to view those logs. I'm considering similar thing to chrome://device-log.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd commit 5a7eae1a5726fa260cfc9e57f753c82e38fdeccd Author: Eriko Kurimoto <elkurin@google.com> Date: Fri Aug 24 08:55:20 2018 Log Page created with ChromeVox+O>W This is the window to show ChromeVox log history. In this patch, the page is created without any contents. Bug: 874349 Change-Id: I6782686f82a8eeab6d85f9c8cc6686564615b1ce Reviewed-on: https://chromium-review.googlesource.com/1175586 Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#585765} [modify] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/BUILD.gn [modify] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json [modify] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js [add] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.css [add] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.html [add] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js [add] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_loader.js [modify] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd [modify] https://crrev.com/5a7eae1a5726fa260cfc9e57f753c82e38fdeccd/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4e7568798771d33aed7dbeb5437653cc1bf9420 commit e4e7568798771d33aed7dbeb5437653cc1bf9420 Author: Eriko Kurimoto <elkurin@google.com> Date: Mon Aug 27 08:07:54 2018 Add speech, earcon,braille and event log to ChromeVox Log page The way to store logs and filter output is general in this patch. Other log type can be easily implemented. In future, console.log output will be removed. Bug: 874349 Change-Id: I4c54869cb23a700cccf6e9f8426c168d7bcf334f Reviewed-on: https://chromium-review.googlesource.com/1177205 Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#586212} [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/BUILD.gn [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/braille/nav_braille.js [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/chromevox/injected/console_tts.js [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/cvox2/background/event_stream_logger.js [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.html [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_loader.js [add] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store.js [modify] https://crrev.com/e4e7568798771d33aed7dbeb5437653cc1bf9420/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1ca8f6fb22b02f57169ae3a207487ac1e6f3a00 commit c1ca8f6fb22b02f57169ae3a207487ac1e6f3a00 Author: Eriko Kurimoto <elkurin@google.com> Date: Mon Aug 27 09:13:30 2018 Implement a ring buffer for this.log_ logs in LogStore is taken always, so adding log process must be fast. In this patch, a ring buffr is implemented. It takes O(1) time to add a log while Javascript shift() takes O(n) time. As a benchmark: 1550ms in average for writeLog 10e+7 times in prior patch. 700 ms in average for writeLog 10e+7 times in this patch. Bug: 874349 Change-Id: I49455787ecbf92583b5f63e838d7970783dc776d Reviewed-on: https://chromium-review.googlesource.com/1179432 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#586216} [modify] https://crrev.com/c1ca8f6fb22b02f57169ae3a207487ac1e6f3a00/chrome/browser/resources/chromeos/chromevox/BUILD.gn [modify] https://crrev.com/c1ca8f6fb22b02f57169ae3a207487ac1e6f3a00/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.html [modify] https://crrev.com/c1ca8f6fb22b02f57169ae3a207487ac1e6f3a00/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js [modify] https://crrev.com/c1ca8f6fb22b02f57169ae3a207487ac1e6f3a00/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store.js [add] https://crrev.com/c1ca8f6fb22b02f57169ae3a207487ac1e6f3a00/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store_test.extjs
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45ff1e77e8f09c34d8b859384b071b971674251a commit 45ff1e77e8f09c34d8b859384b071b971674251a Author: Eriko Kurimoto <elkurin@google.com> Date: Mon Aug 27 12:02:02 2018 Add UI of LogType This UI allows users to know the type of log (speech, event..) easily. Bug: 874349 Change-Id: Ia525731a02752fbc5fa9a29a6aeeeea55c66d2df Reviewed-on: https://chromium-review.googlesource.com/1179116 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by: Yuki Awano <yawano@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586237} [modify] https://crrev.com/45ff1e77e8f09c34d8b859384b071b971674251a/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.css [modify] https://crrev.com/45ff1e77e8f09c34d8b859384b071b971674251a/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.html [modify] https://crrev.com/45ff1e77e8f09c34d8b859384b071b971674251a/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js [modify] https://crrev.com/45ff1e77e8f09c34d8b859384b071b971674251a/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store.js
Comment 1 by yawano@chromium.org
, Aug 15