New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874345 link

Starred by 1 user
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Aug 17
Cc:
█ yoshiki@chromium.org
est...@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Some notifications not hidden when System Tray is opened

Project Member Reported by tetsui@chromium.org, Aug 15 
Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Press Shift-Esc
(2) Open System Tray from the right bottom

What is the expected result?
"Shortcut changed" notification should be dismissed

What happens instead?
It doesn't
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7d16e600638120ead8a232611dabd4ed0f328b

commit 3f7d16e600638120ead8a232611dabd4ed0f328b
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Aug 17 01:26:26 2018

Hide system priority notification popups.

When Chrome OS System Tray is open, all notification popups should be
hidden. After it's closed, system priority notifications should be shown
again. The behavior was broken after new MessagePopupCollection and
subsequent fix https://crrev.com/c/1158118 .

TEST=MessagePopupCollectionTest.HighPriorityNotificationShownAgain
BUG= 874345 

Change-Id: I979adfe1c4632fec356a8ee23ea3544cb1024114
Reviewed-on: https://chromium-review.googlesource.com/1177294
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583921}
[modify] https://crrev.com/3f7d16e600638120ead8a232611dabd4ed0f328b/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/3f7d16e600638120ead8a232611dabd4ed0f328b/ui/message_center/views/message_popup_collection.h
[modify] https://crrev.com/3f7d16e600638120ead8a232611dabd4ed0f328b/ui/message_center/views/message_popup_collection_unittest.cc

Comment 2 by tetsui@chromium.org, Aug 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment