In https://chromium-review.googlesource.com/c/chromium/src/+/1194007/2/chrome/browser/prefs/pref_service_incognito_whitelist.cc#b201

I noticed nothing is calling chrome::ToggleConfirmToQuitOption()

delete it?

> delete it?

yes, thanks for pointing that out.  it's no longer needed

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a49603abde92f812c861569db764b430616a3d9

commit 6a49603abde92f812c861569db764b430616a3d9
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Aug 30 23:38:37 2018

Remove some old confirm-to-quit code

BUG=874341
R=sky

Change-Id: I996a9f57e569acb62eec7e27f8ae0015b92d0ceb
Reviewed-on: https://chromium-review.googlesource.com/1196932
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587843}
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/ui/browser_commands.h
[rename] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/ui/cocoa/confirm_quit.cc
[rename] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/ui/cocoa/confirm_quit.h
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/browser/ui/cocoa/confirm_quit_panel_controller_unittest.mm
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/common/pref_names.cc
[modify] https://crrev.com/6a49603abde92f812c861569db764b430616a3d9/chrome/common/pref_names.h

FWIW, while this bug concerns Ctrl+Shift+Q, there's a similar behavior of Ctrl+Shift+W closing all the tabs.

I put my comment there:

https://bugs.chromium.org/p/chromium/issues/detail?id=537450#c3

TL;DR If you're reverting the toast, please add a confirmation dialog for both Ctrl+Shift+Q and Ctrl+Shift+W instead. It should not be enough to do the combo to close many tabs and lose lots of data.

*** UI Mass Triage ***

Adding appropriate label for expert review.