New issue
Advanced search Search tips

Issue 874337 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 15
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

bisect-kit: optionally check "deps_file" attribute for switch_cros_cr_localbuild_master.py

Project Member Reported by johnylin@chromium.org, Aug 15

Issue description

While using switch_cros_cr_localbuild_master.py, it would have the following error

[stderr] Traceback (most recent call last):
[stderr]   File "./switch_cros_cr_localbuild_master.py", line 97, in <module>
[stderr]     main()
[stderr]   File "./switch_cros_cr_localbuild_master.py", line 82, in main
[stderr]     assert bisect_cr_localbuild_master.verify_gclient_dep(opts.chrome_root)
[stderr]   File "/usr/local/google/home/johnylin/chromiumos/src/platform/bisect-kit/bisect_cr_localbuild_master.py", line 95, in verify_gclient_dep
[stderr]     return solution['deps_file'] == '.DEPS.git'
[stderr] KeyError: 'deps_file'

The content of my .glcient file:

solutions = [
  {
    "url": "https://chromium.googlesource.com/chromium/src.git",
    "managed": False,
    "name": "src",
    "custom_deps": {},
  },
  {
    "name": "src-internal",
    "url": "https://chrome-internal.googlesource.com/chrome/src-internal.git",
    "deps_file": ".DEPS.git"
  },
]
target_os = ["chromeos"]

"src" doesn't have "deps_file" attribute, I think it has default value so actually the attribute is not there in the default .gclient file.



 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/4cc54b5e486fad73c0dc710117a0898dfb173f08

commit 4cc54b5e486fad73c0dc710117a0898dfb173f08
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Wed Aug 15 11:08:19 2018

bisect-kit: revise .gclient file verification for bisect_cr_localbuild_master

BUG= chromium:874337 
TEST=bisect_cr_localbuild_master.py with .gclient file which has no 'deps_file' field

Change-Id: If42afd247de63b16a068057770d3741607e9d71a
Reviewed-on: https://chromium-review.googlesource.com/1175600
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/4cc54b5e486fad73c0dc710117a0898dfb173f08/bisect_cr_localbuild_master.py

Labels: OS-Chrome
Status: Fixed (was: Started)

Sign in to add a comment