audio_Aplay test failure |
|||||||||||
Issue descriptionhttps://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=audio_Aplay&suite=&daysBack=30&board=&architecture=&boardFamily=&buildConfig=&reason=&version=&milestone=70&dut=&token=AGOqsmxhQnu_dJi8UJQaPRdPHO1m%3A1534303524097 This is a regression starting from 10962.0 It seems that there is other thing using audio so the test failed to play with -D. We need to figure out what is using audio. Maybe it is some extension in Chrome. Then, we should check whether it is working as intended, and if true, for the test where we bypass CRAS, we need to stop Chrome.
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3ee6e690868fd5f69c71c1e9b6567e6cebc57ec3 commit 3ee6e690868fd5f69c71c1e9b6567e6cebc57ec3 Author: Yu-Hsuan Hsu <yuhsuan@google.com> Date: Wed Aug 15 23:37:19 2018 [autotest] Stop CRAS before running Aplay test If we run Aplay test while another stream is playing in CRAS, Aplay won't get audio device so that it will return error. We should stop CRAS first to make sure this situation will not happen. BUG= chromium:874336 TEST=Aplay test can pass reliably on peppy and lulu. Change-Id: If50008492b5e889ba3e44117d71367cc70a5b335 Reviewed-on: https://chromium-review.googlesource.com/1175710 Commit-Ready: Yu-Hsuan Hsu <yuhsuan@chromium.org> Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/3ee6e690868fd5f69c71c1e9b6567e6cebc57ec3/client/site_tests/audio_Aplay/audio_Aplay.py
,
Aug 31
The change fixed the bug in the test which fails on M69. So request merge to M69. Thanks.
,
Aug 31
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6
10962.0 is M70, if a regression in that version, why merge to M69?
,
Sep 7
Because the change cause this problem is merged in M69. https://chromium-review.googlesource.com/c/chromium/src/+/1176209 Tahnks!
,
Sep 7
Because this one landed in M71, it should merge into M70 first. So request merge to M70. Thanks. https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1198910
,
Sep 7
,
Sep 10
Oh, sorry. I sent the wrong request. It is already in M70. And it works reliably in M70 so request merge to M69. It is about updating test so it won't break anything. Thanks.
,
Sep 10
+cindyb@ for M69.
,
Sep 11
Merge approved, M69.
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fd56df1acb7fd7064f74c246db85094f35780610 commit fd56df1acb7fd7064f74c246db85094f35780610 Author: Yu-Hsuan Hsu <yuhsuan@google.com> Date: Wed Sep 12 10:19:41 2018 [autotest] Stop CRAS before running Aplay test If we run Aplay test while another stream is playing in CRAS, Aplay won't get audio device so that it will return error. We should stop CRAS first to make sure this situation will not happen. BUG= chromium:874336 TEST=Aplay test can pass reliably on peppy and lulu. Change-Id: If50008492b5e889ba3e44117d71367cc70a5b335 Previous-Reviewed-on: https://chromium-review.googlesource.com/1175710 (cherry picked from commit 96fe31dc33a73b03eed4ed3744d94b546f862c92) Reviewed-on: https://chromium-review.googlesource.com/1221326 Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> [modify] https://crrev.com/fd56df1acb7fd7064f74c246db85094f35780610/client/site_tests/audio_Aplay/audio_Aplay.py
,
Sep 14
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 17
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 19
,
Oct 5
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by cychiang@chromium.org
, Aug 15