The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06d6aef7859cffc2f2331ca055acd41d4be1ad81

commit 06d6aef7859cffc2f2331ca055acd41d4be1ad81
Author: Raymes Khoury <raymes@chromium.org>
Date: Thu Aug 16 06:40:15 2018

Measure the number of embedded content settings set by extensions

This adds a metric which measures the number of times an extension sets
a content setting that has an embedded exception. This means that the
primary and secondary pattern are different.

We plan to deprecate this type of usage for permissions. If usage of
this feature is low for other types of settings we may also consider
deprecating those.

Bug: 802945, 874322 
Change-Id: I5076603eb462cda4495538022c4c3a93c8894519
Reviewed-on: https://chromium-review.googlesource.com/1174082
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583566}
[modify] https://crrev.com/06d6aef7859cffc2f2331ca055acd41d4be1ad81/chrome/browser/extensions/api/content_settings/content_settings_api.cc
[modify] https://crrev.com/06d6aef7859cffc2f2331ca055acd41d4be1ad81/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc
[add] https://crrev.com/06d6aef7859cffc2f2331ca055acd41d4be1ad81/chrome/test/data/extensions/api_test/content_settings/embeddedsettingsmetric/manifest.json
[add] https://crrev.com/06d6aef7859cffc2f2331ca055acd41d4be1ad81/chrome/test/data/extensions/api_test/content_settings/embeddedsettingsmetric/test.html
[add] https://crrev.com/06d6aef7859cffc2f2331ca055acd41d4be1ad81/chrome/test/data/extensions/api_test/content_settings/embeddedsettingsmetric/test.js
[modify] https://crrev.com/06d6aef7859cffc2f2331ca055acd41d4be1ad81/tools/metrics/histograms/histograms.xml

+govind

Any chance this could be merged to 69? It's a 10-line patch for gathering metrics (the rest of the code is a test). It landed on Friday and haven't seen any crash spikes on Canary.

This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Thank you  raymes@.

This is P2, could you pls justify this merge to M69 this late in release cycle? How safe and how critical it is?

It's very safe but not critical. It would just help us get metrics quicker for a feature we'd like to launch in M71. I understand if it's too late in the cycle though.

Thank you raymes@.
We're trying to minimize the merges for M69 at this point, so rejecting merge to M69 as this is not critical based on comment #5. Pls do let me know if there is any concern here.