New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874320 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

CWVTranslationErrorDomain and CWVTranslationError* are not exported

Project Member Reported by ichikawa@chromium.org, Aug 15

Issue description

Owner: jzw@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cdb7d659c0d6b08352ee471f2c441de8122c9b6

commit 8cdb7d659c0d6b08352ee471f2c441de8122c9b6
Author: John Z Wu <jzw@chromium.org>
Date: Thu Aug 16 18:52:14 2018

Export translate errors symbols from ios/web_view.

The client needs these errors to respond properly during runtime.
Also converted to enum declaration to simplify it a little.

Bug:  874320 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idd4af4b966cb856644eaf927fe41c419a8e7eba2
Reviewed-on: https://chromium-review.googlesource.com/1176649
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583761}
[modify] https://crrev.com/8cdb7d659c0d6b08352ee471f2c441de8122c9b6/ios/web_view/internal/translate/cwv_translation_controller.mm
[modify] https://crrev.com/8cdb7d659c0d6b08352ee471f2c441de8122c9b6/ios/web_view/public/cwv_translation_controller.h

Status: Fixed (was: Assigned)

Sign in to add a comment